Skip to content

fix!: registry progress int overflow#133

Open
Racer159 wants to merge 5 commits intomainfrom
fix/registry-progress-overflow
Open

fix!: registry progress int overflow#133
Racer159 wants to merge 5 commits intomainfrom
fix/registry-progress-overflow

Conversation

@Racer159
Copy link
Copy Markdown
Collaborator

Fixes #N/A

This addresses a bug where OCI artifacts which are larger than 2,147,483,647 bytes (~2.1GB) would overflow and show negative progress.

Caution

BREAKING CHANGE
This also changes the progress on a registry pull to show raw bytes so that clients can make more informed decisions on what to do with the progress.

Copy link
Copy Markdown

@CollectiveUnicorn CollectiveUnicorn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified that this works as described and that its a breaking change that outputs bytes instead of the % of progress.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants