Bug/date in filters - #183
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adjusts how useCommandAutocomplete determines a column’s type when formatting unique filter values (notably relevant for date/string quoting behavior) in the renderer.
Changes:
- Updated
useCommandAutocompleteto look upcolumnTypesusing a lowercasedcolumnIdduringloadValues.
Comments suppressed due to low confidence (1)
src/renderer/components/hooks/useCommandAutocomplete/index.ts:130
columnTypesis keyed inconsistently across the app (e.g.CommandLine.tsxuses original column names whileFilterBody.tsxlowercases keys). Changing this lookup tocolumnId.toLowerCase()fixes the latter but breaks the former: whencolumnTypesuses original-case keys,columnTypebecomesundefined, causingformatFilterValueOption(...)to omit quotes for string/date values. It also leaves the latercomparableVariablestype comparison using the old casing logic, so results are still inconsistent.
Consider resolving column types via a small helper that tries both the exact key and a normalized key (and defaults to 'string'), and reuse it for comparableVariables.
const columnType = columnTypes[columnId.toLowerCase()];
const formattedValues = (values[columnId]?.values ?? []).map(
(value) =>
formatFilterValueOption(
value,
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.