Skip to content

Typed params validation in nested blocks#106

Open
AlexanderVasiliev wants to merge 1 commit intodescript-org:masterfrom
AlexanderVasiliev:issue-78-params-types
Open

Typed params validation in nested blocks#106
AlexanderVasiliev wants to merge 1 commit intodescript-org:masterfrom
AlexanderVasiliev:issue-78-params-types

Conversation

@AlexanderVasiliev
Copy link
Copy Markdown
Contributor

This PR fixes #78

Кейсы, которые покрывает:

interface ParamsA {
    a: string;
}

interface ParamsB {
    b: number;
}

de.func({
    // ошибка: дочерний блок ожидает параметры ParamsB
    block: ({ params }: { params: ParamsA }) => {
        return de.http({
            block: {
                pathname: ({ params }: { params: ParamsB }) => `/resource/${params.b}`,
            },
        });
    },
});
const blockNeedsA = de.http({
    block: {
        pathname: ({ params }: { params: ParamsA }) => `/a/${params.a}`,
    },
});

const blockNeedsB = de.http({
    block: {
        pathname: ({ params }: { params: ParamsB }) => `/b/${params.b}`,
    },
});
de.func({
    block: ({ params }: { params: ParamsA }) => {
        return de.object({ // a так же array, first,  pipe
            block: {
                resA: blockNeedsA,
                resB: blockNeedsB, // требует ParamsB, которых нет в ParamsA
            },
        });
    },
});
de.object({
    options: {
        // ошибка:
        params: ({ params }: { params: ParamsA }) => {
            return params; // возвращает ParamsA, но нужно ParamsA & ParamsB
        },
    },
    block: {
        resA: blockNeedsA,
        resB: blockNeedsB,
    },
});
const blockTopLevel = de.func({
    block: ({ params }: { params: ParamsAB }) => {
        return de.http({
            block: {
                pathname: ({ params }: { params: ParamsAB }) => `/ab/${params.a}/${params.b}`,
            },
        });
    },
});

de.run(blockTopLevel, {
     // ошибка:
    params: { a: 'hello' },
});

@AlexanderVasiliev
Copy link
Copy Markdown
Contributor Author

Текст ошибки:

Type 'HttpBlock<unknown, ParamsB, unknown, DescriptHttpBlockResult<unknown>, DescriptHttpBlockResult<unknown>, unknown, unknown, unknown, ParamsB>' is not assignable to type 'DescriptParamsError<ParamsB, ParamsA> | Promise<DescriptParamsError<ParamsB, ParamsA>>'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Проверка params во вложенных объектах

1 participant