feat(env): Phase 1b thin target_host validation - #80
Merged
Merged
Conversation
Expand VALID_DEST_DIRS for peer/slave/users scopes, reject legacy master-apps with a manager-apps suggestion, and document that DAP owns role defaults and identity aliasing. Co-authored-by: Cursor <cursoragent@cursor.com>
Thin authoring check: non-empty string when present. DAP verifies inventory_group membership at compile (Phase 1b). Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
YoungDan
approved these changes
Sep 14, 2026
Those scopes are Observer observation/parse paths (CM push receive side and per-user apps), not GitOps deploy targets. Keep CLI allowlist aligned with D4 deploy destinations only. Co-authored-by: Cursor <cursoragent@cursor.com>
Keep thin authoring allowlist (apps, deployment-apps, manager-apps, shcluster/apps) without peer/slave/users; preserve target_host tests. Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
target_host.inventory_groupat compile.Stacked on Phase 0 allowlist: #79.
Test plan
cargo test --lib target_hostMade with Cursor