Make batching stricter: errors become batch boundaries - #97
Open
destel wants to merge 1 commit into
Open
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #97 +/- ##
==========================================
+ Coverage 99.22% 99.69% +0.46%
==========================================
Files 13 12 -1
Lines 648 647 -1
==========================================
+ Hits 643 645 +2
+ Misses 5 2 -3 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Batch and Unbatch used to split the stream into separate value and error channels internally. That preserved the order of values relative to each other, and likewise the order of errors, but not the order between the two. Both functions now process the stream as a single sequence and preserve the original value-error interleaving:
Unbatch(Batch(s))reproduces the input stream exactly, errors included.This change is bakwards compatible, and for most workloads there are no observable changes. Pipelines that fail fast on the first error, or only aggregate errors at the end, behave as before. Workloads where the relative value-error order matters, now have it deterministic and documented. The one visible difference: streams with mid-stream errors may produce smaller batches, since each error closes the current one.