fixes TAB and RETURN keys behaviour#676
Open
alpha-and-omega wants to merge 1 commit intodevbridge:masterfrom
alpha-and-omega:fix-keyboard-mouse-interface-bug2
Open
fixes TAB and RETURN keys behaviour#676alpha-and-omega wants to merge 1 commit intodevbridge:masterfrom alpha-and-omega:fix-keyboard-mouse-interface-bug2
alpha-and-omega wants to merge 1 commit intodevbridge:masterfrom
alpha-and-omega:fix-keyboard-mouse-interface-bug2
Conversation
|
Excellent fix. Much needed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi!
This patch chages bahaviour when using Tab and Enter to be more consistent with plugin role.
Why:
Warning: it is not easy to understand what is wrong, so be ready for some brain work :)
After using this plugin for some time on production website I realised that there is something wrong with it. Fixing it without changing source code went impossible.
Whats wrong:
This is because active suggestion is changed by mouseover event.
How it should work:
It should be possible to enter any value and finish entering it with Tab or Enter without modification and without generating select action on plugin, wherever mouse pointer is. More strictly - suggestion selection using Tab and Enter should fire only when suggestion was chosen by UP and Down keys, not by mouse.
How to reproduce:
Patch
Patch provided.