Improve MCP stdio transport error handling, add unit test, adjust tests and deps - #7
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Description
StdioTransport::newto returnResult<Self>and useanyhow::Contextfor richer error messages when spawning the subprocess or capturingstdin/stdoutinstead of unwrapping or panicking.MCPClient::register_serverto propagate theResultfromStdioTransport::new(use?) so callers handle transport construction failures.stdio_transport_spawn_failure_returns_errorto verify that attempting to spawn a non-existent MCP command returns an error.test_vector_storeandtest_config) to use US English spellings and make assertions more precise by comparingPathBufvalues directly; updateREADME.mdtest docs accordingly.package.json(notably@milkdown/plugin-math,@milkdown/plugin-table, and@tauri-apps/api) and include a smallCargo.lockchange forthiserror.voice.rs(British → American spelling) and small tidy-ups to error handling code paths.Testing
cargo testwhich includes unit tests and integration tests, and the test suite completed successfully including the newstdio_transport_spawn_failure_returns_errorunit test.test_vector_storeandtest_configintegration tests ran as part ofcargo testand passed after the test assertion adjustments.Codex Task