Make MCP StdioTransport fallible, add tests, and small robustness/docs fixes - #8
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Description
StdioTransport::newto returnResult<Self>and useanyhow::Contextfor richer error messages instead of panicking on spawn or I/O capture failures.register_serverto propagate the fallibleStdioTransport::newwith?.gitmodule robustness by usingOid::ZERO_SHA1and handling potential errors frompath()andshorthand()calls more defensively.stdio_transport_spawn_failure_returns_errorto ensure invalid MCP commands return an error instead of panicking, and make small spelling/documentation changes in test files and comments.package.jsonandCargo.lockto align versions.Testing
cargo testwhich includes the new unit teststdio_transport_spawn_failure_returns_error, and all unit and integration tests completed successfully.test_vector_store*,test_config) which passed as part of the test run.Codex Task