misc: Release candidate v0.46.0#390
Merged
Merged
Conversation
Added AssumeRoleArn field across all services that interact with ECR: common-lib: - helmLib/registry: Configuration bean + extractCredentialsForRegistry - utils/bean: DockerAuthConfig.AssumeRoleArnEcr - utils/dockerOperations: LoadEcrCredentials with AssumeRole kubelink: - gRPC proto: AssumeRoleArn field (tag 15) on RegistryCredential - adapter: pass AssumeRoleArn to registry Configuration ci-runner: - DockerCredentials struct + DockerLogin: STS AssumeRole before ECR auth - CommonWorkflowRequest: AssumeRoleArn field - GetDockerAuthConfigForPrivateRegistries: pass ARN - Added log lines for cross-account login confirmation image-scanner: - DockerArtifactStore model: AssumeRoleArn field - RoundTripperService: STS AssumeRole in GetAuthenticatorByDockerRegistryId
The DockerCredentials literal in StartDockerDaemonAndDockerLogin was missing AssumeRoleArn, causing ec2rolecreds fallback failure in pods. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
- Move DockerfileScanRequest and ScanConfig to dedicated bean file - Remove polling logic from InitiateDockerfileScan (fail-fast) - Handle filepath.Abs error and improve error logging - Add panic recovery to asynchronous scan goroutine - Remove unused IgnoredRules field and cleanup code
- CI-Runner now blindly trusts Orchestrator's decision - Removed: DockerfileScanEnabled OR ForceDockerfileScan check - Now uses: DockerfileScanEnabled only (Orchestrator computes OR logic) - Orchestrator passes pre-computed shouldScan in DockerfileScanEnabled field - This ensures single source of truth for scan decision Architecture: - Orchestrator: Decides (userEnabled OR orgForced) - CI-Runner: Executes blindly (no decision logic) - Image-Scanner: Executes blindly (no decision logic) Part of Phase 1: Simplified Dockerfile scan architecture Co-authored-by: Qwen-Coder <qwen-coder@alibabacloud.com>
…tManager build error - Added tests for Success, MissingFile, and ServerError scenarios in DockerfileScanHelper - Fixed pre-existing compilation error in GitManager_test.go (CloneAndCheckout signature mismatch) - Tests verify scan request payload, error handling, and graceful degradation Co-authored-by: Qwen-Coder <qwen-coder@alibabacloud.com>
- Remove duplicate endpoint definition by reusing PubSubConfig - Remove unnecessary flags (DockerfileScanEnabled/ForceDockerfileScan) from request payload - Reduce log noise by removing redundant error handling in non-critical path Co-authored-by: Qwen-Coder <qwen-coder@alibabacloud.com>
misc: main sync
misc: vendor files
feat: add docker scan
…isory fix: dependabot security advisory
…me-role feat: ecr cross account assume role
…isory sync: new dependabot security fixes
prkhrkat
requested review from
prakarsh-dt,
vikramdevtron and
vivek-devtron
as code owners
vikramdevtron
approved these changes
Apr 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.