test: enforce cloud engine invariants by default in system tests#9609
Conversation
type4 nodes and enforce it in system tests
type4 nodes and enforce it in system testsThere was a problem hiding this comment.
This pull request changes code owned by the Governance team. Therefore, make sure that
you have considered the following (for Governance-owned code):
-
Update
unreleased_changelog.md(if there are behavior changes, even if they are
non-breaking). -
Are there BREAKING changes?
-
Is a data migration needed?
-
Security review?
How to Satisfy This Automatic Review
-
Go to the bottom of the pull request page.
-
Look for where it says this bot is requesting changes.
-
Click the three dots to the right.
-
Select "Dismiss review".
-
In the text entry box, respond to each of the numbered items in the previous
section, declare one of the following:
-
Done.
-
$REASON_WHY_NO_NEED. E.g. for
unreleased_changelog.md, "No
canister behavior changes.", or for item 2, "Existing APIs
behave as before.".
Brief Guide to "Externally Visible" Changes
"Externally visible behavior change" is very often due to some NEW canister API.
Changes to EXISTING APIs are more likely to be "breaking".
If these changes are breaking, make sure that clients know how to migrate, how to
maintain their continuity of operations.
If your changes are behind a feature flag, then, do NOT add entrie(s) to
unreleased_changelog.md in this PR! But rather, add entrie(s) later, in the PR
that enables these changes in production.
Reference(s)
For a more comprehensive checklist, see here.
GOVERNANCE_CHECKLIST_REMINDER_DEDUP
- Only test changes
- Only test changes
- Only test changes, no migration needed
- No security review either
26a236f to
06bd053
Compare
There is a registry invariant that enforces that cloud engines must have a free cycles cost schedule. A separate PR will add a second invariant enforcing that cloud engines must contain only
type4node reward types, as this is already how nodes deny incoming connections from cloud engine nodes in the firewall.This PR ensures those two invariants are satisfied when creating cloud engines in system tests by default (though can still be broken if needed by calling
with_cost_schedule/with_node_reward_type).Moreover, note that this means that it becomes a requirement for any system test running a cloud engine to also have an API BN. As of
HEAD, cloud engines already use API BNs to replicate the registry (because NNS nodes' firewall blocks them). Existing system tests using cloud engines work because the nodes' reward types are not set in the registry, thus default to contacting NNS nodes. Soon (draft PR), fetching delegations will also go through API BNs.This PR thus also adds an API BN to existing tests that use cloud engines.