Skip to content

feat(ic-icrc1): add ICRC-122 AuthorizedMint/AuthorizedBurn candid types, index-ng, and .did support#9694

Draft
bogwar wants to merge 10 commits intoicrc-122-1-typesfrom
icrc-122-3-candid-index-ng
Draft

feat(ic-icrc1): add ICRC-122 AuthorizedMint/AuthorizedBurn candid types, index-ng, and .did support#9694
bogwar wants to merge 10 commits intoicrc-122-1-typesfrom
icrc-122-3-candid-index-ng

Conversation

@bogwar
Copy link
Copy Markdown
Contributor

@bogwar bogwar commented Apr 1, 2026 •
edited
Loading

Summary

  • Add AuthorizedMint/AuthorizedBurn Candid structs and Transaction fields in icrc-ledger-types
  • Replace all panic stubs with real implementations:
    • index-ng: balance credit/debit for authorized mints/burns, account extraction
    • endpoints: Block-to-Transaction conversion
    • lib.rs: Transaction::apply balance operations
    • test_utils and in_memory_ledger: balance tracking
  • Update ledger.did, archive.did, and index-ng.did with new types
  • Align Candid structs with ICRC-122/152 specs: no memo, include created_at_time
  • Fix schema: use is_more_or_equal_to(0) for amt to accept Nat64 from CBOR decoder; add tx.ts (created_at_time) as required in strict (ICRC-152) mode
  • Add BlockBuilder::authorized_mint() and BlockBuilder::authorized_burn() for constructing ICRC-122 test blocks
  • Fix btype in blocks_strategy for AuthorizedMint/AuthorizedBurn

Test plan

Unit tests (rs/ledger_suite/icrc1/tests/tests.rs)

  • CBOR round-trip: encode block → decode → all fields preserved, for both AuthorizedMint and AuthorizedBurn
  • Hash stability: generic block hash matches encoded block hash after round-trip
  • btype correctness: blocks have btype set to "122mint" / "122burn"
  • Candid conversion: Block → Transaction produces correct kind, populates the right struct with correct fields (including created_at_time), all other operation fields are None
  • ICRC-152 schema validation: blocks with caller, mthd, and ts (created_at_time) pass validate_152_mint/validate_152_burn
  • ICRC-122 schema validation: blocks without caller/mthd/ts pass permissive validate_mint/validate_burn but fail strict ICRC-152 validators

Unit tests (rs/ledger_suite/icrc1/ledger/src/tests.rs)

  • Transaction::apply: AuthorizedMint credits account, AuthorizedBurn debits account, AuthorizedBurn with insufficient balance returns error

Integration tests (rs/ledger_suite/icrc1/index-ng/tests/tests.rs)

  • Full index-ng pipeline via icrc3_test_ledger: load AuthorizedMint/AuthorizedBurn blocks → sync index-ng → verify balances are correct (credit/debit)
  • get_account_transactions: returns correct kind ("122mint"/"122burn") and correct operation fields for authorized operations
  • Minimal ICRC-122 block: block without caller/mthd (permissive schema) is indexed correctly

Proptest

  • AuthorizedMint/AuthorizedBurn strategies added to operation_strategy (currently disabled pending Rosetta support — Rosetta proptests use blocks_strategy and would hit panic stubs)

🤖 Generated with Claude Code

@bogwar @claude
feat(ic-icrc1): add ICRC-122 AuthorizedMint/AuthorizedBurn candid typ…
72ca322 
…es, index-ng, and .did support

- Add AuthorizedMint/AuthorizedBurn Candid structs and Transaction fields
- Replace panic stubs with real implementations in index-ng
  (balance changes and account extraction), endpoints (Block-to-Transaction
  conversion), test_utils, in_memory_ledger, and Transaction::apply
- Update ledger.did, archive.did, and index-ng.did with new types

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@bogwar bogwar requested a review from Copilot April 1, 2026 07:57
@github-actions github-actions bot added the feat label Apr 1, 2026
Copilot AI reviewed Apr 1, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds support for ICRC-122 AuthorizedMint and AuthorizedBurn transaction types to the ledger system. The changes include adding new Candid structs and transaction fields in icrc-ledger-types, replacing panic stubs with real implementations for balance operations across multiple modules (index-ng, endpoints, lib.rs, test_utils, in_memory_ledger), and updating the .did files with the new types.

Changes:

  • Add AuthorizedMint and AuthorizedBurn Candid structs and fields to the Transaction type in icrc-ledger-types
  • Implement balance credit/debit operations for authorized mints/burns in index-ng, lib.rs, and test utilities
  • Add Block-to-Transaction conversion support for the new operation types in endpoints
  • Update ledger.did, archive.did, and index-ng.did with AuthorizedMint and AuthorizedBurn type definitions

Reviewed changes

Copilot reviewed 10 out of 10 changed files in this pull request and generated no comments.

Show a summary per file
File Description
packages/icrc-ledger-types/src/icrc3/transactions.rs Adds AuthorizedMint/AuthorizedBurn structs, new constants, Transaction fields, and helper methods
rs/ledger_suite/icrc1/src/endpoints.rs Implements Block-to-Transaction conversion for AuthorizedMint/AuthorizedBurn operations
rs/ledger_suite/icrc1/src/lib.rs Implements balance operations (mint/burn) for authorized operations
rs/ledger_suite/icrc1/test_utils/src/lib.rs Adds balance credit/debit and account validity tracking for authorized operations
rs/ledger_suite/test_utils/in_memory_ledger/src/lib.rs Implements process_mint/process_burn for authorized operations
rs/ledger_suite/icrc1/index-ng/src/main.rs Implements balance changes and account extraction for authorized operations
rs/ledger_suite/icrc1/ledger/ledger.did Adds AuthorizedMint/AuthorizedBurn type definitions
rs/ledger_suite/icrc1/archive/archive.did Adds AuthorizedMint/AuthorizedBurn type definitions
rs/ledger_suite/icrc1/index-ng/index-ng.did Adds AuthorizedMint/AuthorizedBurn type definitions
rs/ledger_suite/icrc1/index-ng/tests/tests.rs Updates test Transaction initialization with new fields

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

bogwar and others added 7 commits April 1, 2026 08:08
@bogwar @claude
fix(ic-icrc1): remove memo/created_at_time from AuthorizedMint/Author…
cecbc6a 
…izedBurn Candid types

ICRC-122 block schema defines tx fields as {mthd, to/from, amt, caller,
reason} — memo and created_at_time are not part of the standard. Remove
them from the Candid structs, endpoint conversion, and .did files.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@bogwar @claude
test(ic-icrc1): add ICRC-122 AuthorizedMint/AuthorizedBurn tests
c654057 
- CBOR round-trip: encode/decode preserves all fields and btype
- Hash stability: generic block hash matches encoded block hash
- Candid conversion: Block→Transaction produces correct kind and fields
- Schema validation: blocks with caller/mthd pass ICRC-152 validators,
  blocks without them pass ICRC-122 but fail ICRC-152
- Transaction::apply: AuthorizedMint credits, AuthorizedBurn debits,
  insufficient balance fails
- Proptest: extend operation_strategy to generate AuthorizedMint/AuthorizedBurn
- Fix btype in blocks_strategy for AuthorizedMint/AuthorizedBurn
- Fix schema: use is_more_or_equal_to(0) for amt to accept Nat64 from
  CBOR decoder (same approach as ts field)

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@bogwar @claude
fix(ic-icrc1): add created_at_time to AuthorizedMint/AuthorizedBurn p…
bf4d440 
…er ICRC-152

ICRC-152 canonical tx mapping includes created_at_time as a tx field
(used for deduplication). Add it back to Candid structs, endpoint
conversion, .did files, and schema validators.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@bogwar @claude
fix(ic-icrc1): use tx.ts for created_at_time in schema and tests per …
e326c5f 
…CBOR encoding

The FlattenedTransaction serializes created_at_time as "ts" in CBOR.
Update schema validators to check for "ts" inside tx (matching what
the encoder produces), make it required in strict (ICRC-152) mode,
and fix test helpers to pass created_at_time for ICRC-152 blocks.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@bogwar @claude
fix: add authorized_mint/authorized_burn fields to Transaction litera…
aa4cfe1 
…ls in sns and nervous_system tests

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@bogwar @claude
fix: remove duplicate comment in tests
2fc7c2b 
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@bogwar @claude
fix: disable AuthorizedMint/AuthorizedBurn in proptest strategy until…
c20cd4e 
… Rosetta support

The blocks_strategy is used by Rosetta proptests which still have panic
stubs for these variants. Comment out the new strategies until Rosetta
PR implements real handling.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@bogwar bogwar requested a review from mbjorkqvist April 1, 2026 22:05
bogwar and others added 2 commits April 2, 2026 09:00
@bogwar @claude
feat(ic-icrc1-test-utils): add AuthorizedMint/AuthorizedBurn block bu…
8c03d01 
…ilders

Add BlockBuilder::authorized_mint() and BlockBuilder::authorized_burn()
methods for constructing ICRC-122 blocks as ICRC3Value. These can be
used with the icrc3_test_ledger to test index-ng and Rosetta integration
with the new block types.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@bogwar @claude
test(index-ng): add integration tests for AuthorizedMint/AuthorizedBu…
277600e 
…rn via icrc3_test_ledger

Test the full pipeline: load ICRC-122 blocks into the test ledger,
sync index-ng, and verify:
- Balances are correct (authorized mint credits, authorized burn debits)
- get_account_transactions returns correct kind and operation fields
- Minimal ICRC-122 blocks (no caller/mthd) are indexed correctly

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@bogwar bogwar requested a review from Copilot April 2, 2026 09:11
Copilot AI reviewed Apr 2, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 16 out of 16 changed files in this pull request and generated no new comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@mbjorkqvist mbjorkqvist Awaiting requested review from mbjorkqvist

Assignees

No one assigned

Labels

feat

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@bogwar