Skip to content

refactor: introduce strum::EnumIter to protobuf's NodeRewardType#9702

Open
pierugo-dfinity wants to merge 3 commits intomasterfrom
pierugo/protobuf/node-reward-type-enumiter
Open

refactor: introduce strum::EnumIter to protobuf's NodeRewardType#9702
pierugo-dfinity wants to merge 3 commits intomasterfrom
pierugo/protobuf/node-reward-type-enumiter

Conversation

@pierugo-dfinity
Copy link
Copy Markdown
Contributor

@pierugo-dfinity pierugo-dfinity commented Apr 1, 2026

This PR adds strum::EnumIter to NodeRewardType to make it future-proof to iterate over all its variants in case a new one gets added (mostly done in tests for now).

Base automatically changed from pierugo/registry/invariant-type4-nodes to master April 2, 2026 13:38
@pierugo-dfinity pierugo-dfinity force-pushed the pierugo/protobuf/node-reward-type-enumiter branch from 958d387 to 7eef2ac Compare April 2, 2026 13:51
@pierugo-dfinity pierugo-dfinity marked this pull request as ready for review April 2, 2026 15:45
@pierugo-dfinity pierugo-dfinity requested review from a team as code owners April 2, 2026 15:45
Copy link
Copy Markdown
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This pull request changes code owned by the Governance team. Therefore, make sure that
you have considered the following (for Governance-owned code):

  1. Update unreleased_changelog.md (if there are behavior changes, even if they are
    non-breaking).

  2. Are there BREAKING changes?

  3. Is a data migration needed?

  4. Security review?

How to Satisfy This Automatic Review

  1. Go to the bottom of the pull request page.

  2. Look for where it says this bot is requesting changes.

  3. Click the three dots to the right.

  4. Select "Dismiss review".

  5. In the text entry box, respond to each of the numbered items in the previous
    section, declare one of the following:

  • Done.

  • $REASON_WHY_NO_NEED. E.g. for unreleased_changelog.md, "No
    canister behavior changes.", or for item 2, "Existing APIs
    behave as before.".

Brief Guide to "Externally Visible" Changes

"Externally visible behavior change" is very often due to some NEW canister API.

Changes to EXISTING APIs are more likely to be "breaking".

If these changes are breaking, make sure that clients know how to migrate, how to
maintain their continuity of operations.

If your changes are behind a feature flag, then, do NOT add entrie(s) to
unreleased_changelog.md in this PR! But rather, add entrie(s) later, in the PR
that enables these changes in production.

Reference(s)

For a more comprehensive checklist, see here.

GOVERNANCE_CHECKLIST_REMINDER_DEDUP

@pierugo-dfinity pierugo-dfinity dismissed github-actions[bot]’s stale review April 2, 2026 15:46
  1. No need, chore change in test code.
  2. No.
  3. No.
  4. No need.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants