Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #316.
sortsilently ignores a callable comparator whose truth value is false. The same presence checks also bypass the documented comparator/key conflict when either supplied callable is false-valued.Use explicit None checks for the two guards. Six regression cases cover ascending/reverse behavior with a false-valued comparator, all three false-valued conflict combinations, in-place identity, and a false-valued key supplied alone. Include a changelog entry and the contributor credit required by CONTRIBUTING.
Validation:
inv cion Linux 3.12.15 passed: sdist/wheel build, Sphinx with warnings treated as errors, Ruff format/lint, mypy, generated chaining-type consistency, and all tests. Windows mypy andgit diff --checkpassed too.Disclosure: this contribution was prepared and checked by an AI coding agent. The reproduction comes from local source inspection, not a reported production incident. Automated code review is not human maintainer approval.