Repository navigation
Preserve blank query values when combining URLs - #318
Merged
dgilland merged 2 commits intoOct 17, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
URL query parameters with empty values are silently dropped when parsing existing paths:
url("https://example.com/path?a=&b=1")returns onlyb=1, while an empty string supplied through keyword arguments is kept.Preserve blank values when parsing each path's query string. Add six regression/compatibility cases covering explicit and bare empty values, repeated keys, an empty key, multiple paths, and keyword parameters. The tests compare complete URLs so parsing the expected result cannot hide a missing parameter.
Validation:
tox run -e py310,py311,py312,py313,py314: all five environments passedinv ci, including package/docs builds, ruff, mypy, generated chaining-type consistency, and 2,482 tests/doctests per version with 100% coverage.AI assistance: Codex assisted with reproduction, implementation, regression tests, validation, diff review, and PR preparation.