Repository navigation
Keep anchored replacements at string boundaries - #321
Merged
dgilland merged 1 commit intoOct 18, 2026
Merged
Conversation
Signed-off-by: Yusuf Efe <120668197+yuefdev@users.noreply.github.com>
|
coverage: 100.0%. remained the same — yuefdev:fix/replacement-string-boundaries into dgilland:develop |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
replace_start()andreplace_end()promise string boundaries, but^and$allow interior line boundaries withre.MULTILINE.$also matches before a final newline without that flag, soreplace_end("foo\n", "foo", "X")incorrectly returns"X\n".Use the absolute string anchors
\Aand\Z. Regression cases cover literal suffixes, final newlines, compiled and inline multiline flags, both boundaries together and valid boundary matches.Checks: three regressions fail before the fix; all 689 string tests and doctests pass afterwards. Ruff lint/format and
git diff --checkpass.Prepared and verified with AI assistance (OpenCode, gpt-6.1-sol).