Repository navigation
Sort generic mapping values in order_by - #325
Merged
dgilland merged 2 commits intoOct 18, 2026
Merged
Conversation
|
coverage: 100.0%. remained the same — Gambit-Checkmate:fix/order-by-mappings into dgilland:develop |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #323.
Use the existing
Mappingabstraction when extractingorder_byinput values, matching the declared input contract. UserDict and MappingProxyType currently return sorted keys instead of values.Regression tests cover dict, UserDict and read-only mappings in ascending/descending order, retaining the original input. Four generic mapping cases failed before the fix; two dict controls passed. Added an unreleased changelog entry.
Full suite: 2,646 passed, 100% coverage.
Validation
-W), sdist/wheel build, generated chaining types comparison andgit diff --checkpassed.AI disclosure: prepared with OpenAI Codex assistance. Found through code inspection and reproduced locally; no production incident is claimed.