Repository navigation
Honor supplied object customizers regardless of truth value - #331
Merged
dgilland merged 3 commits intoOct 18, 2026
Merged
Conversation
dgilland
requested changes
Oct 18, 2026
dgilland
left a comment
Owner
There was a problem hiding this comment.
Tests shouldn't go into a new test file. Instead put them in the appropriate test_<submodule>.py file that already exists.
Also, merge conflicts need resolution (I don't have permission to resolve them).
Since you have several PRs that all modified AUTHORS.rst and CHANGELOG.rst, each subsequent PR is going to conflict with the previously merged one. I don't mind resolving those conflicts myself, but you will need grant me permission to do so for each PR.
…le suite Resolve AUTHORS/CHANGELOG conflicts while preserving upstream changes. Keep the regression tests beside existing module tests, as requested in review.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
assign_with(), set_with() and update_with() silently skip valid callable customizers whose bool returns False or whose len returns zero. A callback that disallows boolean conversion raises before it is called.
Distinguish an absent customizer from a supplied callable with explicit None checks. Keep existing positional/keyword callback handling, None-result fallback, and non-callable container templates.
Review follow-up: all 18 regression/control cases now live in the existing
tests/test_objects.pybeside the related tests. Merged latestdevelop(542fefa) and resolved the conflicts while preserving upstream changes. The contributor entry is already upstream, so this PR no longer changesAUTHORS.rst.Local validation on Python 3.12.14: 2722 tests passed in the project-default unit/doctest scope (
pytest src/pydash tests --ignore=tests/pytest_mypy_testing --cov=pydash), with 100% library statement coverage. Full Ruff lint and format checks, project-scope mypy (src/pydash,tests,tasks.py), generated chaining-stub comparison, and whitespace checks passed. Upstream CI is tracked separately in Checks.Prepared with OpenAI Codex assistance. No production usage or independent human review is claimed.