fix: [ANDROSDK-2383] send the right category option combo params when downloading data value files - #2710
Merged
Conversation
|
vgarciabnz
approved these changes
Sep 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
File resources attached to aggregate data values were never downloaded when the data set had an attribute category combo. The request to
/api/dataValues/fileswas passing the data value's attribute option combo in thecoparameter, which the API interprets as the category option combo, and it never sent theccandcpparameters that identify the attribute option combo. The server answered409 Data value does not exist, and the error was swallowed by the download call, so the file was silently missing. It only worked by accident when both combos were the default one, since they share the same uid.The fix sends
cowith the data value's own category option combo and resolves the attribute option combo locally intocc(its category combo) andcp(its semicolon-separated category options), mirroring whatDataSetCompleteRegistrationNetworkHandlerImplalready does. The bug has been present since the aggregate file downloader was introduced in 1.7.0, so this is not a regression.Related task: ANDROSDK-2383