chore: [ANDROSDK-2384] review dataSet download flow - #2713
Open
taridepaco wants to merge 3 commits into
Open
taridepaco wants to merge 3 commits into
taridepaco wants to merge 3 commits into
Conversation
remove paging=false fix default future periods number
inherit dataValueSet properties in dataValues missing them
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
/api/dataValueSetsrequest was not constraining the attributeOptionCombo, which forces a much slower query plan on the server. It now sends the attributeOptionCombos of the dataSet being downloaded, resolved from the local metadata. Thepaging=falseparameter is also dropped: it is not a supported parameter of this endpoint and is ignored by the backend. On top of that, the number of future periods was stored with a different default than the one used to build the bundle, so the comparison inAggregatedDataSyncLastUpdatedCalculatornever matched and dataSets withoutopenFuturePeriodswere fully re-downloaded on every sync instead of incrementally.The attributeOptionCombos are only added while they fit in the maximum url length, falling back to the previous unfiltered query otherwise, since sending a truncated list would silently skip the data values of the omitted combos. Partitioning the request to keep it within both the url and the payload limits is handled in ANDROSDK-2203.
Related task: ANDROSDK-2384