Feat rn atomic css #1788
Open
Feat rn atomic css #1788
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-atomic-css-upgrade
feat: upgrade unocss
hiyuki
reviewed
Jun 25, 2025
|
|
||
| function formatValue (value) { | ||
| function createFormatValue (formatValueFn) { | ||
| formatValueFn = formatValueFn || 'global.__formatValue' |
Collaborator
There was a problem hiding this comment.
确认一下global是否可以访问，以及当前这个formatValueFn是在哪挂的？
hiyuki
reviewed
Jun 25, 2025
| let staticClass = el.attrsMap[className + '-class'] || '' | ||
| let staticStyle = getAndRemoveAttr(el, className + '-style').val || '' | ||
| staticClass = staticClass.replace(/\s+/g, ' ') | ||
| if (unoStaticHoverClass) { |
feat: rn-css-layer
…date-unocss-esm-dd
Feat update unocss esm dd
hiyuki
reviewed
Dec 9, 2025
| let checkApplyReg | ||
| if (this.options.transformCSS) { | ||
| const checkApplyList = this.options.transformCSS.applyVariable || ['--at-apply', '--uno-apply', '--uno'] | ||
| checkApplyReg = new RegExp(`(${checkApplyList.join('|')})(\s)?\:`) |
Collaborator
There was a problem hiding this comment.
为啥不把这个放到cssRequiresTransform中
hiyuki
reviewed
Dec 9, 2025
| let result = isNativeStaticStyle ? [] : {} | ||
| const mergeResult = isNativeStaticStyle ? (...args) => result.push(...args) : (...args) => Object.assign(result, ...args) | ||
| // 使用一下 __getSizeCount 触发其 get | ||
| this.__getSizeCount() |
hiyuki
reviewed
Dec 9, 2025
| mergeResult(localStyle._default) | ||
| mergeToLayer('normal', localStyle._default) | ||
| } | ||
| } else if (unoClassMap[className]) { |
Collaborator
There was a problem hiding this comment.
unoClassMap整体需要参考local/appclassmap的按需执行设计，并且需要支持rpx，vw等样式刷新
Collaborator
There was a problem hiding this comment.
unoClassMap能合到AppClassMap中吗，包括preflightMap
hiyuki
reviewed
Dec 9, 2025
| // 使用一下 __getSizeCount 触发其 get | ||
| this.__getSizeCount() | ||
|
|
||
| const { mergeToLayer, genResult } = createLayer(isNativeStaticStyle) |
Collaborator
There was a problem hiding this comment.
需要进行一个测速，添加了unocss逻辑之后getStyle的耗时增加了多少，
hiyuki
reviewed
Dec 9, 2025
| mergeToLayer(importantClass ? 'important' : 'uno', unoClass) | ||
| if (unoClass.transform || unoClass.filter) needAddUnoPreflight = true | ||
| } else if (unoVarClassMap[className]) { | ||
| mergeToLayer('important', unoVarClassMap[className]._default) |
hiyuki
reviewed
Dec 9, 2025
| }) | ||
|
|
||
| compiler.hooks.beforeCompile.tapPromise(PLUGIN_NAME, async (compilation) => { | ||
| const ctx = await createContext(configOrPath, defaults) |
hiyuki
reviewed
Dec 9, 2025
| function processUnoPseudo (staticClass, unoCtx) { | ||
| const { config } = unoCtx | ||
| const separators = config.separators.join('|') | ||
| const pseudoClassReg = new RegExp(`(hover)(?:${separators})`) // 目前仅处理了 hover 状态 |
Collaborator
There was a problem hiding this comment.
感觉不需要处理这个，应该让用户在hover-class当中写原子类，不过小程序和web需要支持一下
hiyuki
reviewed
Dec 9, 2025
| }, '') | ||
| if (ctorType === 'app') { | ||
| if (hasUnoCSS) { | ||
| output += ` |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.