feat: add React 19.2.X support (@react-pdf/reconciler) #3224
+152
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 17ed299 The changes in this PR will be included in the next version bump. This PR includes changesets to release 7 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Hello, do you know if there is any planned release with this update? |
|
We would also need it, could this be merged? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses reconciler incompatibility issue in #3223
Opening this up to kick things off with some initial fixes to support the reconciler changes in React 19.2.0.
Unfortunately, I'm still getting the
TypeError: Cannot read properties of null (reading 'props')errors experienced in that issue and some occurrences of Invalid hook call. Hooks can only be called inside of the body of a function component., which might still need to be addressed in other components of react-pdf for full 19.2.X compatibility.The Invalid Hook error seems to be new to React 19.2.0, however, on version 19.1.0, the props error occurs running the latest NPM version of
@react-pdf/renderer.Additionally, this makes the version check in the reconciler's
index.tsmore flexible for future releases and revisions to react-reconciler as necessary.