Skip to content

fix(sse): preserve tools echo on response.completed lifecycle event (… - #9003

Merged
diegosouzapw merged 1 commit into
diegosouzapw:release/v3.8.50from
SofDev007:fix/8990-preserve-tools-response-completed
Aug 6, 2026
Merged

fix(sse): preserve tools echo on response.completed lifecycle event (…#9003
diegosouzapw merged 1 commit into
diegosouzapw:release/v3.8.50from
SofDev007:fix/8990-preserve-tools-response-completed

Conversation

@SofDev007

@SofDev007 SofDev007 commented Jul 30, 2026

Copy link
Copy Markdown
Contributor

#8990)

stripResponsesLifecycleEcho stripped tools from all three Responses lifecycle events. response.completed is the terminal snapshot Codex CLI rebuilds its tool list from, so stripping it left the client with zero tools. Scope the tools deletion to response.created/in_progress only, mirroring the response.completed special-case already used by backfillResponsesCompletedOutput. instructions stripping (the >100KB size lever, not reported broken) is unchanged on all three events.

Fixes #8990

Summary

  • Describe the user-facing or operational change.

Related Issues

  • Closes #
  • Related to #

Validation

Run only the focused loop for what you changed — the full unit suite, Vitest, the
60% coverage gate, and the production build all run in CI on this PR (#8329):

  • Focused tests for the change: node --import tsx/esm --test tests/unit/<file>.test.ts
  • npm run lint
  • Production-code changes include a new or updated automated test in this PR
  • SonarQube PR analysis is green or any remaining issues are explicitly documented below

Tests Added Or Updated

  • List every changed or added automated test file.
  • If no production code changed, state that here.

Coverage Notes

  • If this PR changes src/, open-sse/, electron/, or bin/, explain which tests cover the change.
  • If coverage moved down in any touched file, explain why and what follow-up task will recover it.

Reviewer Notes

  • Call out any risky areas, migrations, feature flags, or manual validation that reviewers should know about.

…8990)

stripResponsesLifecycleEcho stripped tools from all three Responses
lifecycle events. response.completed is the terminal snapshot Codex CLI
rebuilds its tool list from, so stripping it left the client with zero
tools. Scope the tools deletion to response.created/in_progress only,
mirroring the response.completed special-case already used by
backfillResponsesCompletedOutput. instructions stripping (the >100KB
size lever, not reported broken) is unchanged on all three events.

Fixes #8990
@SofDev007
SofDev007 requested a review from diegosouzapw as a code owner July 30, 2026 18:24
@diegosouzapw
diegosouzapw merged commit c996dc9 into diegosouzapw:release/v3.8.50 Aug 6, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

fix: stripResponsesLifecycleEcho deletes tools from all Responses lifecycle events

2 participants