fix(sse): preserve tools echo on response.completed lifecycle event (… - #9003
Merged
diegosouzapw merged 1 commit intoAug 6, 2026
Conversation
…8990) stripResponsesLifecycleEcho stripped tools from all three Responses lifecycle events. response.completed is the terminal snapshot Codex CLI rebuilds its tool list from, so stripping it left the client with zero tools. Scope the tools deletion to response.created/in_progress only, mirroring the response.completed special-case already used by backfillResponsesCompletedOutput. instructions stripping (the >100KB size lever, not reported broken) is unchanged on all three events. Fixes #8990
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…#8990)
stripResponsesLifecycleEcho stripped tools from all three Responses lifecycle events. response.completed is the terminal snapshot Codex CLI rebuilds its tool list from, so stripping it left the client with zero tools. Scope the tools deletion to response.created/in_progress only, mirroring the response.completed special-case already used by backfillResponsesCompletedOutput. instructions stripping (the >100KB size lever, not reported broken) is unchanged on all three events.
Fixes #8990
Summary
Related Issues
Validation
Run only the focused loop for what you changed — the full unit suite, Vitest, the
60% coverage gate, and the production build all run in CI on this PR (#8329):
node --import tsx/esm --test tests/unit/<file>.test.tsnpm run lintTests Added Or Updated
Coverage Notes
src/,open-sse/,electron/, orbin/, explain which tests cover the change.Reviewer Notes