test: use filename string instead of pathlib.Path to fix tests using diffpy.structure#128
Conversation
…`diffpy.structure`
|
Warning! No news item is found for this PR. If this is a user-facing |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #128 +/- ##
==========================================
- Coverage 67.05% 66.99% -0.07%
==========================================
Files 25 25
Lines 3160 3163 +3
==========================================
Hits 2119 2119
- Misses 1041 1044 +3
🚀 New features to boost your workflow:
|
|
@sbillinge, it's ready for review. The "Check for News" failed because the branch was renamed. The correct news item was added in the PR. |
tests/test_pdf.py
Outdated
|
|
||
| stru = PDFFitStructure() | ||
| ciffile = datafile("ni.cif") | ||
| ciffile = str(ciffile) |
There was a problem hiding this comment.
let's change the variable name to cif_path.
Please can you also make an issue on diffpy.structure to have loadStructure accept pathlib.Path or string, i.e., any valid path object.?
There was a problem hiding this comment.
Please can you also make an issue on diffpy.structure to have loadStructure accept pathlib.Path or string, i.e., any valid path object.?
Yes, there was already an issue diffpy/diffpy.structure#124
ycexiao
left a comment
ycexiao
left a comment
There was a problem hiding this comment.
@sbillinge, it's ready for review.
| stru = PDFFitStructure() | ||
| ciffile = datafile("ni.cif") | ||
| stru.read(ciffile) | ||
| cif_path = str(ciffile) |
| pc.loadData(datafile("ni-q27r100-neutron.gr")) | ||
| ni = loadStructure(datafile("ni.cif")) | ||
| ciffile = datafile("ni.cif") | ||
| cif_path = str(ciffile) |
2 participants
What problem does this issue address?
Fix tests involving
diffpy.structureas mentioned in #90 (comment)What should the reviewer(s) do?
Please check the modifications.