Skip to content

fix: fix load_structure method with loading Path object.#185

Open
stevenhua0320 wants to merge 1 commit intodiffpy:v3.4.0from
stevenhua0320:fix-load-structure
Open

fix: fix load_structure method with loading Path object.#185
stevenhua0320 wants to merge 1 commit intodiffpy:v3.4.0from
stevenhua0320:fix-load-structure

Conversation

@stevenhua0320
Copy link
Contributor

@stevenhua0320 stevenhua0320 commented Mar 14, 2026

@sbillinge ready to review. Note that I do miss this one in the deprecation process, so in the meanwhile of fix it I also deprecate the method here. Since it originally does not have a test for reading Path object, I add a test at the end.
Closes #124

@codecov
Copy link

codecov bot commented Mar 14, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.20%. Comparing base (991889b) to head (4f7656c).
⚠️ Report is 5 commits behind head on v3.4.0.

Additional details and impacted files
@@            Coverage Diff             @@
##           v3.4.0     #185      +/-   ##
==========================================
+ Coverage   99.17%   99.20%   +0.02%     
==========================================
  Files          15       15              
  Lines        2439     2501      +62     
==========================================
+ Hits         2419     2481      +62     
  Misses         20       20              
Files with missing lines Coverage Δ
tests/test_loadstructure.py 98.07% <100.00%> (+0.57%) ⬆️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant