-
Notifications
You must be signed in to change notification settings - Fork 45
feat: @digdir/designsystemet-web
#4409
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
🦋 Changeset detectedLatest commit: 398c2a4 The changes in this PR will be included in the next version bump. This PR includes changesets to release 5 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Tobias Barsnes <[email protected]> Co-authored-by: Oddbjørn Øvernes <[email protected]>
…f Designsystemet (#4321) Co-authored-by: Barsnes <[email protected]> Co-authored-by: Michael Marszalek <[email protected]>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Michael Marszalek <[email protected]>
Co-authored-by: Michael Marszalek <[email protected]>
|
Preview deployments for this pull request: storybook - themebuilder - www - |
Co-authored-by: Michael Marszalek <[email protected]>
| @@ -0,0 +1,4 @@ | |||
| import '@digdir/designsystemet-css'; | |||
| import '@digdir/designsystemet-theme'; | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Assume this was supposed to be theme file?
| import '@digdir/designsystemet-theme'; | |
| import '@digdir/designsystemet-css/theme'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok, but why alias a deprecated package at not just use the new package/method for fetching theme, or for that matter just relative paths?
|
|
||
| ### Med command og uten context | ||
|
|
||
| Dersom du ikke vil bruke `Dialog.TriggerContext`, kan du bruke `command="show-modal"` eller `command="--show-non-modal"` og `commandfor="DIALOG-ID"` for å åpne dialogen fra en ekstern trigger. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Given that this may be the first place some developers see command and commandfor, should we perhaps add a little info-box or something in these places invoker-commands are mentioned, that this is actually a new part of the web standard, link to the google developers post or mdn article, and note that we automatically polyfill this (I know it is mentioned in the readme, but it is maybe useful to include here as well)?

resolves #1044
resolves #3348
resolves #4369
resolves #4433
Edit by @mimarz: Moved some links to resolving issues from other closed PRs which feat was moved to this PR instead.
Summary
First implementation of a new package that properly uses pure web, and has no dependencies like react.
Related to #1044
You can test this package with the npm tag
test.The preview comment is a bit buried, so putting links here as well:
Checks
pnpm changesetif relevant)