Repository navigation
fix: include column headers in offline SQL results - #13
Merged
Merged
Conversation
dingxin-tech
marked this pull request as ready for review
October 5, 2026 02:04
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SQLTask.getResulttreated the first data row of an offline SQL result as its CSV header. A three-row no-primary-key batch upload therefore appeared to return two rows, even though table download still reported three.Emit the result's column names before its rows. This keeps the existing CSV escaping, LF line endings and
\Nnull marker, leaves SQLRT/tunnel output unchanged, and retains schema for empty SELECTs without adding output to non-query statements.Fixes #12.
Validation:
go test -race ./...andgo vet -unreachable=false ./...: passed.createUploadSession -> openBufferedWriter -> close -> commit -> SQLTask.getResultwith all three rows and values. A legacy Maven profile and CI step preserve this regression alongside the default SDK suite.SeaTunnel's E2E remains not run due to its separate 65-module build environment requirement. This PR does not re-enable its disabled test or update its emulator image. No real cloud services were used.
GitHub acceptance run 37215698073 passed on
ff7bd72772cd8c580487e5fee139f8c461896e02, including modern and legacy SDKs, JDBC, PyODPS and C++ probes.