fix(acp): validate workspace access before session admission - #108
Merged
Merged
Conversation
Run workspace metadata and directory access checks in the existing blocking pool before admitting runtime work. Preserve project-scoped command contracts and add thread-boundary and desktop API regression coverage. Refs #108
Initialize synthetic provider provenance explicitly, import canonical test constants after the main merge, and synchronize workspace package versions in Cargo.lock. Refs #108
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Background
When a conversation workspace was deleted, moved, or became inaccessible, the ACP adapter still attempted to use it as the working directory and failed with:
This made a workspace problem appear to be an
npx.cmdor Agent environment failure.Changes
workspace.path-not-foundworkspace.path-not-directoryworkspace.path-inaccessibleprojectIdandworkspacePathin error parametersBehavior
Verification
cargo fmt --all --check