Community event modal: fix banner overlap, add YouTube embeds - #11
Merged
Conversation
Move the banner image inside the existing space-y-6 wrapper so it is no longer a direct child of DialogContent's grid. In the grid context, the aspect-video container could collapse, letting the absolutely positioned Image fill overlap the description and highlights when the modal scrolled. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Adds an optional videos field on Event that accepts YouTube URLs in several formats (watch?v=, youtu.be, /shorts, /embed). The dialog renders each as a lazy-loaded, fullscreen-enabled nocookie iframe in its own Videos section, between Links and Gallery. Wires up the Infinite Days 2023 talk recording. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
space-y-6wrapper so it is no longer a direct child ofDialogContent's grid layout.videos?: string[]field toEventand render a new "Videos" section in the modal between Links and Gallery. URLs are normalized toyoutube-nocookie.com/embed/<id>and rendered as responsive, lazy-loaded, fullscreen-enabled iframes.Community.dialog.videostranslation in en/fr.Test plan
/community, click any event card without videos — the modal renders with no Videos section and content/banner do not overlap when scrolling./fr/communityand confirm the section heading shows "Vidéos".watch?v=,youtu.be/, and/shorts/URL locally and confirm each embeds correctly.🤖 Generated with Claude Code