Open
Conversation
This also fixes durability lost for *some* other reasons. Off the top of my head, Poison and fire damage no longer reduces durability. "PROJECTILE" damage also won't reduce durability, but what's weird is that Hoshiyumi uses ENTITY_ATTACK damage type instead of PROJECTILE damage type (though, that's a result of using Utility.damage() )
Contributor
Author
|
not like "item is now unbreakable" is an issue, thanks magnet/demonaura |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This also fixes durability lost for some other reasons.
Off the top of my head, Poison and fire damage no longer reduces durability. "PROJECTILE" damage also won't reduce durability, but what's weird is that Hoshiyumi uses ENTITY_ATTACK damage type instead of PROJECTILE damage type (though, that's a result of using Utility.damage() )
Took me a few hours to make PR because I was testing to make sure it worked. At least with comet, it works properly; though I feel like I've missed an item that is now unbreakable...