cloudflare: omit unsupported --keep-vars for wrangler versions upload#702
Merged
Conversation
Agent-Logs-Url: https://github.com/dmno-dev/varlock/sessions/8210be2a-a23e-4533-b419-1adf2eec4683 Co-authored-by: theoephraim <1158956+theoephraim@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix invalid '--keep-vars' flag in varlock-wrangler
cloudflare: omit unsupported May 13, 2026
--keep-vars for wrangler versions upload
- Add process.exitCode assignment in handleDeploy and handleTypes so wrangler failures correctly exit non-zero (fixes #703) - Remove copilot-generated test file (unnecessary) - Update changeset to cover both fixes
Contributor
|
The changes in this PR will be included in the next version bump.
|
commit: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


varlock-wranglertreateddeployandversions uploadidentically and always appended--keep-vars=false. Wrangler 4.x does not support that flag onversions upload, causing hard failure withUnknown arguments: keep-vars, keepVars.CLI argument handling
versions upload.--keep-vars=falsefordeploy, notversions upload.Focused regression coverage
varlock-wranglerargument construction using a stubbedwranglerbinary.versions uploaddoes not receive--keep-vars=falsedeploydoes receive--keep-vars=falseWarning
Firewall rules blocked me from connecting to one or more addresses (expand for details)
I tried to connect to the following addresses, but was blocked by firewall rules:
api.iconify.design/opt/hostedtoolcache/node/24.14.1/x64/bin/node /opt/hostedtoolcache/node/24.14.1/x64/bin/node --experimental-import-meta-resolve --require /home/REDACTED/work/varlock/varlock/node_modules/.bun/vitest@4.1.5+aa8dd106732c7af1/node_modules/vitest/suppress-warnings.cjs --conditions node --conditions development /home/REDACTED/work/varlock/varlock/node_modules/.bun/vitest@4.1.5+aa8dd106732c7af1/node_modules/vitest/dist/workers/forks.js(dns block)If you need me to access, download, or install something from one of these locations, you can either: