Skip to content

feat(nvim): open all multi-selected files on cr#544

Merged
dmtrKovalenko merged 1 commit into
dmtrKovalenko:mainfrom
gshahbazian:gabe/multi-select-cr
Jun 28, 2026
Merged

feat(nvim): open all multi-selected files on cr#544
dmtrKovalenko merged 1 commit into
dmtrKovalenko:mainfrom
gshahbazian:gabe/multi-select-cr

Conversation

@gshahbazian

@gshahbazian gshahbazian commented May 31, 2026

Copy link
Copy Markdown
Contributor

if multiple files are selected (using <tab>) then return should
open all of them. snacks picker works this way and i think most
will expect it.

@dmtrKovalenko dmtrKovalenko left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have tried on snacks nvim and I don't see what they are doing it opens one of the match , and I am not sure what are you trying to do here.

Mayve you can upload the video of what you are performing? I think it might make more sense to open a new tab for every file (but I personally hate tabs)

Comment thread tests/picker_dir_resolution_spec.lua Outdated
@gshahbazian

Copy link
Copy Markdown
Contributor Author

@dmtrKovalenko this change opens a buffer for each multi-selected file. i will add a video for you when i get some time.

@gshahbazian gshahbazian force-pushed the gabe/multi-select-cr branch from 2551806 to 3f38040 Compare June 27, 2026 23:17
@gshahbazian

Copy link
Copy Markdown
Contributor Author

steps:

  • open picker
  • tab to select multiple files
  • hit return

snacks picker

snacks.mov

opens all selected


fff main

fff-main.mov

open only the first selection


fff this branch

fff-feature.mov

opens all selected

@dmtrKovalenko

@gshahbazian gshahbazian force-pushed the gabe/multi-select-cr branch from 3f38040 to c5346f4 Compare June 27, 2026 23:22
@dmtrKovalenko dmtrKovalenko merged commit a0008b1 into dmtrKovalenko:main Jun 28, 2026
43 of 52 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants