feat: expose follow_symlinks for SDK/MCP/python paths#628
Merged
Conversation
Owner
|
@gustav-fff fix the issues and triple check if it doesn't create ABI compatibiltiy issue |
Collaborator
Author
|
[triage-bot] DIRECTED: pushed 54bc368. ABI issue found and fixed: Triple-checked the rest:
Honk-Honk 🪿 |
Closes #627 Bumps FFF_CREATE_OPTIONS_VERSION to 2 (append-only). Adds --follow-symlinks flag to fff-mcp, follow_symlinks kwarg to the pyo3 finder, and followSymlinks option to @ff-labs/fff-node. Default stays false everywhere; follow_symlinks is preserved across reindex in C and Python. Watcher cycle handling is unchanged — caller must ensure the indexed tree has no symlink loops.
54bc368 to
39c05f2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #627
Root cause
follow_symlinkswas hardcoded tofalseon every non-nvim entry point:crates/fff-c/src/lib.rs:295and:1047,crates/fff-mcp/src/main.rs:265,crates/fff-python/src/finder.rs:246and:775. Reporter's stowed config layout (~/.pi/agent→~/.dotfiles/...) is invisible to fff-node / fff-mcp / fff-python because of this.Fix
FFF_CREATE_OPTIONS_VERSIONto 2 and appendfollow_symlinks: booltoFffCreateOptions(append-only, ABI layout test extended to assert the new offset 82). Old v1 callers continue to work — whenopts.version < 2the field is ignored andfollow_symlinksdefaults tofalse.fff-mcp: add--follow-symlinksCLI flag.fff-python: addfollow_symlinks=Falsekwarg toFileFinder.__init__; preserved acrossreindex.@ff-labs/fff-node: addfollowSymlinks?: booleantoInitOptions, threaded throughffiCreateand the FFI struct.fff-c: preservefollow_symlinksacrossfff_change_directory(was being dropped tofalse).crates/fff-c/include/fff.hviacbindgen.Default stays
falseeverywhere. Watcher cycle detection is unchanged — caller is responsible for ensuring the indexed tree has no symlink loops. Documented in the option doc comments.Steps to reproduce
How verified
cargo test -p fff-c— 9 passed including the ABI layout test (size_of == 88, new field at offset 82).cargo build -p fff-c -p fff-mcp -p fff-python— clean.Holding on watcher loop guards per maintainer call — flag exposure only as discussed in #627.
Automated triage via Gustav. Honk-Honk 🪿