Fix: respect required: false for env_file in publish command#13650
Closed
maks2134 wants to merge 5 commits intodocker:mainfrom
Closed
Fix: respect required: false for env_file in publish command#13650maks2134 wants to merge 5 commits intodocker:mainfrom
maks2134 wants to merge 5 commits intodocker:mainfrom
Conversation
added 5 commits
March 17, 2026 00:16
Resolves race condition between main thread calling Done() and UI thread calling printWithDimensions(). The issue was that Done() held the mutex while sending to the done channel, but the UI thread needed the same mutex to process the done signal. Fixed by sending the done signal before acquiring the mutex, allowing the UI thread to receive the signal and release any held locks. Fixes docker#13639
# Conflicts: # cmd/display/tty_test.go
- Change format flag default from "table" to empty string to allow config override - Add logic to use PsFormat from config when no format argument provided - Fall back to "table" format when neither PsFormat nor format arg is set - Add warning when both --format and --quiet flags are used - Add test to verify format flag default value Fixes docker#13643 Signed-off-by: maks2134 <maks210306@yandex.by>
Fixes docker#13648 The docker compose publish command was ignoring required: false setting on env_file entries, causing failures when optional env files were missing. Changes made: - Modified checkForSensitiveData() to skip env files with required: false - Updated processFile() to only process required env files into layers - Fixed checkEnvironmentVariables() to only consider required env files - Added comprehensive tests to verify the fix Signed-off-by: Maks Kozlov <maks@example.com> Signed-off-by: maks2134 <maks210306@yandex.by>
maks2134
force-pushed
the
fix/env-file-required-false-in-publish
branch
from
ca55904 to
5b111bb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What I did
Fixed the docker compose publish command to properly handle env_file entries with
required: false. The command was previously ignoring this setting and failing when optional env files were missing.Changes made:
required: falseRelated issue
fixes #13648
(not mandatory) A picture of a cute animal, if possible in relation to what you did