Add glob_files tool for finding files by name pattern#2342
Closed
trungutt wants to merge 4 commits intodocker:mainfrom
Closed
Add glob_files tool for finding files by name pattern#2342trungutt wants to merge 4 commits intodocker:mainfrom
trungutt wants to merge 4 commits intodocker:mainfrom
Conversation
Adds a new built-in glob_files tool that lets the agent find files by glob pattern (e.g. **/*.go, src/**/*.ts). Results are sorted by modification time and capped at 100 files, matching the behavior of similar tools in other coding agents. Includes TUI rendering component and unit tests.
- Fix gci import ordering: separate doublestar from internal imports - Fix perfsprint: use string concatenation instead of fmt.Sprintf - Update all 6 e2e cassettes to include glob_files instruction text - Add glob_files tool definition to 5 fs_tools cassettes (OpenAI, Anthropic, Gemini, Mistral)
- Add canonicalizeJSON to DefaultMatcher so property ordering in tool definitions doesn't cause mismatches between request and cassette bodies - Update cassette instruction text for new glob_files tool - Add glob_files tool definition to fs_tools cassettes - Fix gci import ordering and perfsprint lint error
Use actual Go provider SDK serialization for tool definitions: - OpenAI/Mistral: makeAllRequired transforms (path becomes required+nullable) - Anthropic: raw schema preserved - Gemini: raw schema preserved - Revert proxy.go matcher changes (not needed with correct cassettes) - Instruction text updated in all 6 cassettes
Member
|
@trungutt we used to have that but the llm would use bash instead |
Contributor
Author
|
Yep, current it's not blocking, it's nice to have. Otherwise the LLM will do |
Contributor
|
/review (i'm just testing the action, @trungutt, you can ignore this comment) |
|
❌ PR Review Failed — The review agent encountered an error and could not complete the review. View logs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
glob_filestool that lets the agent find files by glob pattern (e.g.**/*.go,src/**/*.ts,*.json).gitignore)Globtool found in other coding agents (e.g. Claude Code, OpenCode)Assisted by OpenCode