feat: support custom providers in RAG embedding and reranking models#2344
Open
dgageot wants to merge 1 commit intodocker:mainfrom
Open
feat: support custom providers in RAG embedding and reranking models#2344dgageot wants to merge 1 commit intodocker:mainfrom
dgageot wants to merge 1 commit intodocker:mainfrom
Conversation
Thread the Providers map from the agent config through RuntimeConfig, ManagersBuildConfig, and BuildContext so that custom provider definitions (e.g. a local Ollama instance with a custom base_url) are applied when creating embedding and reranking model providers. Add a NewProvider helper on both ManagersBuildConfig and BuildContext to encapsulate the repeated provider.New + WithGateway + WithProviders pattern. Consolidate duplicate resolveModelConfig logic in builder.go by reusing strategy.ResolveModelConfig. Also fixes missing WithProviders in semantic_embeddings.go chat model creation and missing WithGateway in reranking provider creation. Closes docker#1701 Assisted-By: docker-agent
aheritier
approved these changes
Apr 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Thread the
Providersmap from the agent config throughRuntimeConfig,ManagersBuildConfig, andBuildContextso that custom provider definitions (e.g. a local Ollama instance with a custombase_url) are applied when creating embedding and reranking model providers.Changes
Providersfield toRuntimeConfig,ManagersBuildConfig, andBuildContextNewProviderhelper on bothManagersBuildConfigandBuildContextto encapsulate the repeatedprovider.New+WithGateway+WithProviderspatternresolveModelConfiglogic inbuilder.goby reusingstrategy.ResolveModelConfigWithProvidersinsemantic_embeddings.gochat model creationWithGatewayin reranking provider creationCloses #1701