-
Notifications
You must be signed in to change notification settings - Fork 4
feat!: Add apiKey support to API requests
#202
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
apiKey support to API requestsapiKey support to API requests
:java_duke: JaCoCo coverage report
|
|
||||||||||||||
|
HTML test reports are available as workflow artifacts (zipped HTML). • Download: Artifacts for this run |
65727a2 to
320e74b
Compare
- Introduced `apiKey` field for secure authentication in configuration and API requests. - Updated clear and task APIs to accept enhanced request objects. - Added required tests and assertions for `apiKey` handling across all request types. - Refactored HTTP operations to include `apiKey` in request headers. - Introduced new classes for managing authentication details. Fixes docling-project#187 Signed-off-by: Eric Deandrea <[email protected]>
|
HTML test reports are available as workflow artifacts (zipped HTML). • Download: Artifacts for this run |
|
HTML test reports are available as workflow artifacts (zipped HTML). • Download: Artifacts for this run |
|
HTML test reports are available as workflow artifacts (zipped HTML). • Download: Artifacts for this run |
|
@edeandrea I'm a bit unsure about the API Key support. Wouldn't that be part of the Docling Client implementation (since it's about establishing the HTTP Client connection) instead of having it included in every API request object? When I imagine an implementation of From a user perspective, especially when using this in the context of a framework like Quarkus or Spring Boot, it means you cannot just inject a Basically, I think we're missing centralised API Key configuration. What do you think about keeping the What do you think? |
|
You know what - I think you are 100% correct. The api key should be treated like the base url - a property of the api as a whole, not an individual request. I'll fix this. Thank you for catching it. |
1 similar comment
|
You know what - I think you are 100% correct. The api key should be treated like the base url - a property of the api as a whole, not an individual request. I'll fix this. Thank you for catching it. |
|
No worries :) thanks for looking into this! |
apiKeyfield for secure authentication in configuration and API requests.apiKeyhandling across all request types.apiKeyin request headers.Fixes #187