Add $unwind stage tests#165
Open
alinaliBQ wants to merge 6 commits intodocumentdb:mainfrom
Open
Conversation
Signed-off-by: Daniel Frankcom <frankcom@amazon.com> Signed-off-by: Alina (Xi) Li <Alina.Li@improving.com> Fix error return value Signed-off-by: Alina (Xi) Li <Alina.Li@improving.com>
init.py Signed-off-by: Alina (Xi) Li <Alina.Li@improving.com> split into test cases Signed-off-by: Alina (Xi) Li <Alina.Li@improving.com> Put lambda tests into StageTestCase Signed-off-by: Alina (Xi) Li <Alina.Li@improving.com> split test cases Signed-off-by: Alina (Xi) Li <Alina.Li@improving.com> add missing test cases Signed-off-by: Alina (Xi) Li <Alina.Li@improving.com> remove duplicate test cases Signed-off-by: Alina (Xi) Li <Alina.Li@improving.com> changes after rebase Signed-off-by: Alina (Xi) Li <Alina.Li@improving.com> unwind integration tests Signed-off-by: Alina (Xi) Li <Alina.Li@improving.com> Address feedback Signed-off-by: Alina (Xi) Li <Alina.Li@improving.com> Address Feedback Use long form consistently Signed-off-by: Alina (Xi) Li <Alina.Li@improving.com> address feedfback Remove transform Signed-off-by: Alina (Xi) Li <Alina.Li@improving.com> address feedback Signed-off-by: Alina (Xi) Li <Alina.Li@improving.com>
documentdb-triage-tool
Bot
added
compatibility test
|
🤖 Auto-triaged by documentdb-triage-tool. Applied: Reasoningcomponent from path globs (test-coverage, test-framework); effort from diff stats (3254+1 LOC, 20 files); LLM: Adds new integration test coverage for the $unwind aggregation stage operator, touching the compatibility tests path. If a label is wrong, remove it manually and ping |
Collaborator
danielfrankcom
left a comment
danielfrankcom
left a comment
There was a problem hiding this comment.
Looks good - just a couple of minor comments
Merge Test files group these files together: - test_unwind_errors_path_syntax.py + test_unwind_errors_preserve_and_fields.py - test_unwind_dotted_path.py + test_unwind_dotted_path_options.py - test_unwind_include_array_index.py + test_unwind_index_field_name_acceptance.py - test_unwind_scalar_passthrough.py + test_unwind_unicode.py - test_unwind_mixed_shape.py + test_unwind_nested_arrays.py + test_unwind_multi_stage.py Signed-off-by: Alina (Xi) Li <Alina.Li@improving.com>
remove Javascript code add non-existent collection tests add ignore_doc_order=true to avoid flaky tests put large array test to standalone Signed-off-by: Alina (Xi) Li <Alina.Li@improving.com>
remove error precedence Signed-off-by: Alina (Xi) Li <Alina.Li@improving.com>
Signed-off-by: Alina (Xi) Li <Alina.Li@improving.com>
alinaliBQ
commented
May 6, 2026
Author
alinaliBQ
left a comment
alinaliBQ
left a comment
There was a problem hiding this comment.
Addressed comments from Daniel
danielfrankcom
approved these changes
May 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change adds tests for the $unwind stage operator.
Add stage operator tests for $unwind. Tests database $unwind behavior, syntax, and expected errors.
Integration tests are in
documentdb_tests/compatibility/tests/core/operator/stages/test_stages_position_unwind.py