Skip to content

building with json-schema #5

Description

@neonstalwart

the build automatically discovers the json-schema package.json and sets the location for json-schema to be json-schema/lib based on the "directories" directive in the package.json. this causes the json-schema/lib/validate dependency to cause an error for the build since the build resolves that as json-schema/lib/lib/validate.

not sure what to do about this...

  1. use json-schema/validate as the dependency but configure the loader to set the location for the json-schema package to be json-schema/lib. this is not ideal since the default loader config won't work.
  2. change json-schema's package.json so that the build discovers json-schema/lib/validate as expected. this is not ideal since other node packages probably already rely on the "directories" directive.
  3. instruct people to include the following in their build profile - which is also not ideal since the default build profile config won't work.
{
    name: 'json-schema',
    location: 'json-schema',
    resourceTags: {
        amd: function (filename) {
            return /\/lib\/(?:links|validate)\.js$/.test(filename);
        }
    }
},

i guess this issue could probably belong in the json-schema repo but i'm reporting it here in the hope that adopters of dmodel will find this issue before complaining about how it isn't working.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions