Type Venom platform links#2950
Draft
MarkMcCaskey wants to merge 1 commit into
Draft
Conversation
Model the platform target GObj, signed smash-taunt timer, and vertically ordered joints as a dedicated Ground variable payload. This removes pointer/integer round trips without changing unrelated Venom payload views. All five consumers remain exact matches.
ribbanya
reviewed
Jul 23, 2026
Comment on lines
+503
to
+508
| struct grVenom_Platform_GroundVars { | ||
| /* +00 gp+C4 */ Ground_GObj* target_gobj; | ||
| /* +04 gp+C8 */ s32 smash_taunt_timer; | ||
| /* +08 gp+CC */ HSD_JObj* upper_jobj; | ||
| /* +0C gp+D0 */ HSD_JObj* lower_jobj; | ||
| }; |
Collaborator
There was a problem hiding this comment.
I think based on previous PRs your Claude already understands this, but if you look at any given StageCallbacks[], it's basically setting up an array of runtime-typed objects:
StageCallbacks grVe_StageCallbacks[16] = {
{
grVenom_80203F98, // GObj 0, callback 0
grVenom_80203FC4, // GObj 0, callback 1
grVenom_80203FCC, // GObj 0, callback 2
grVenom_80203FD0, // GObj 0, callback 3
0,
},
{
grVenom_80206B94, // GObj 1, callback 0
grVenom_80206BBC, // GObj 1, callback 1
grVenom_80206BC4, // GObj 1, callback 2
grVenom_80206BEC, // GObj 1, callback 3
(1 << 29),
},With this in mind, we know that for any given set of callbacks (StageCallbacks struct), the same union member is used for GroundVars. Two StageCallbacks elements sharing the same GroundVars union member is probably quite common as well. Like in this case, you might be able to pick out multiple GObjs which are semantically venom_platform.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Splitting #2936 up into serial reviewable chunks. I'm going to leave this PR as a draft until I have time to provide more evidence beyond inferring from the static structure here. Hopefully by tonight / tomorrow night. I'll make some experiments and distill them as gecko codes to test it out in the game and confirm more about the naming here before this needs to be reviewed.
From Codex: