Skip to content

[ci-status] Run az.cmd through cmd.exe on Windows - #13630

Open
jonathanpeppers wants to merge 3 commits into
mainfrom
jonathanpeppers-fix-ci-failures-az-windows
Open

jonathanpeppers wants to merge 3 commits into
mainfrom
jonathanpeppers-fix-ci-failures-az-windows

Conversation

@jonathanpeppers

@jonathanpeppers jonathanpeppers commented Nov 18, 2026 •

Copy link
Copy Markdown
Member

On Windows, ci_failures.cs fails when it starts the Azure CLI:

System.ComponentModel.Win32Exception (2): An error occurred trying to start process 'az' ... The system cannot find the file specified.

On Windows, the Azure CLI is az.cmd. With UseShellExecute = false, Process.Start does not use PATHEXT, so az does not resolve to az.cmd.

Starting az.cmd by name does not work either: az.cmd prints Failed to load python executable., because %~dp0 does not resolve to its folder. Run it as cmd.exe /d /c az.cmd ... instead, and quote each argument so cmd.exe does not treat & in the Azure DevOps URLs as a command separator. macOS and Linux still run az directly.

Quoting does not escape a " inside an argument, so --build-id must now contain only ASCII digits.

Run now uses the .NET 11 Process.RunAndCaptureText (psi, timeout) instead of reading stdout/stderr, waiting, and killing the process itself. KillOnParentExit = true stops the az process under cmd.exe from running after the script exits. After a timeout, the output captured before the timeout is lost; the timeout message is still reported.

Tested on Windows:

dotnet run .github/skills/ci-status/scripts/ci_failures.cs -- --build-id 1688444 --pr 13619 --format json

Exit code 0; JSON output with 3 failures and 0 errors. A --build-id value of 1" & echo injected & rem " prints the usage message and exits with 1.

On Windows, `ci_failures.cs` fails when it starts the Azure CLI:

    System.ComponentModel.Win32Exception (2): An error occurred trying to start process 'az' ... The system cannot find the file specified.

On Windows, the Azure CLI is `az.cmd`. With `UseShellExecute = false`, `Process.Start` does not use `PATHEXT`, so `az` does not resolve to `az.cmd`.

Starting `az.cmd` by name does not work either: `az.cmd` prints `Failed to load python executable.`, because `%~dp0` does not resolve to its folder. Run it as `cmd.exe /d /c az.cmd ...` instead, and quote each argument so cmd.exe does not treat `&` in the Azure DevOps URLs as a command separator. macOS and Linux still run `az` directly.

Tested on Windows:

    dotnet run .github/skills/ci-status/scripts/ci_failures.cs -- --build-id 1688444 --pr 13619 --format json

Exit code 0; JSON output with 3 failures and 0 errors.
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Copilot AI balanced review requested due to automatic review settings November 18, 2026 22:21

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

The build ID is not validated before shell invocation, allowing embedded quotes to bypass argument quoting and execute arbitrary commands through cmd.exe on Windows.

1 open issue
What changed in this PR

Updates the repository’s CI failure-analysis script to launch Azure CLI through cmd.exe on Windows, while preserving direct execution on macOS and Linux.

Changes:

  • Selects az.cmd on Windows and az elsewhere.
  • Routes .cmd commands through cmd.exe /d /c and quotes arguments to protect URL ampersands.
File Description
.github/​skills/​ci-status/​scripts/​ci_failures.cs Adds platform-specific Azure CLI selection and Windows batch-command handling.

Review effort: Balanced

@jonathanpeppers jonathanpeppers added the ready-to-review This PR is ready to review/merge, I think any CI failures are just flaky (ignorable). label Nov 19, 2026
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
@jonathanpeppers

Copy link
Copy Markdown
Member Author

@dalexsoto review

@dalexsoto dalexsoto left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed c8b94366 against main at 78ef747b. This is a static, read-only review.

The cmd.exe /d /c az.cmd "..." approach looks right for what this script passes: with --build-id now restricted to ASCII digits, every az argument is a constant, an integer, or an ID returned by Azure DevOps, so the &s stay inside the quotes and there is no % or " to escape. Non-Windows still goes through ArgumentList.

One thing to fix before merging:

ci_failures.cs:1054 - KillOnParentExit = true adds a CA1416 warning that ends up in the JSON output

ProcessStartInfo.KillOnParentExit is [SupportedOSPlatform] only for android, linux and windows. This file-based app targets plain net11.0 (supported platforms Linux, macOS and Windows), and neither the root .editorconfig nor Directory.Build.props/Directory.Build.targets changes CA1416's default Warning severity, so the unguarded assignment produces CA1416.

Whenever the script has to be rebuilt, that warning goes to stdout: dotnet run builds at quiet verbosity, which still prints warnings, and with stdout redirected it uses the plain console logger, which writes to stdout. SKILL.md runs dotnet run ... --format json > /tmp/ci-analysis.json and then runs jq on that file. So on a fresh checkout (including environments set up by copilot-setup-steps.yml, which doesn't pre-build the script) and on the first run after the script changes, the warning line is written ahead of the JSON. The build succeeds and the script runs normally, but the jq steps then fail to parse the file. As far as I can tell the script built without warnings before this change. Separately, when RunningOnCI or _AndroidTreatWarningsAsErrors is set, the root Directory.Build.props (which file-based apps import) turns this into a build error.

Either move it out of the initializer behind a platform check:

if (OperatingSystem.IsWindows () || OperatingSystem.IsLinux ())
    psi.KillOnParentExit = true;

or wrap the assignment in #pragma warning disable CA1416 / #pragma warning restore CA1416. The setter doesn't throw on macOS and has no effect there, so suppressing the warning is also safe.

Non-blocking: on timeout, Process.RunAndCaptureText calls Kill() on the direct child only, whereas the previous code used Kill(entireProcessTree: true). On Windows the direct child is now cmd.exe, so a timed-out az call can leave the python process started by az.cmd running.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
@jonathanpeppers

Copy link
Copy Markdown
Member Author

@dalexsoto review

@dalexsoto dalexsoto left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 013b312a against main at 550ac207. This is a static, read-only review.

The CA1416 issue from my last review is fixed. KillOnParentExit is now set only under OperatingSystem.IsWindows () || OperatingSystem.IsLinux (). Both platforms are in the property's [SupportedOSPlatform] set (android/linux/windows, unchanged from rc.1 through GA), and the analyzer accepts that guard. Without the warning, a rebuild can't write it into the JSON that SKILL.md redirects to a file, and TreatWarningsAsErrors on CI has nothing to escalate.

I also re-checked the rest of the change:

  • The cmd.exe line: nothing in it needs escaping. Everything is a constant, the digits-only --build-id, an integer, or a timeline GUID or log ID returned by Azure DevOps. pr/repo only go to gh through ArgumentList. /d keeps registry AutoRun output out of stdout.
  • API availability: Process.RunAndCaptureText (psi, timeout) and KillOnParentExit are in the rc.3 SDK that copilot-setup-steps.yml installs.
  • Callers: the (code, stdout, stderr) result and the JSON output types are unchanged, so AzJson/AzText and the SKILL.md jq steps behave as before.
  • Non-Windows: macOS and Linux still run az with ArgumentList.

Non-blocking:

  • As noted last time, a timeout now kills only the direct child (cmd.exe on Windows, the az wrapper on macOS/Linux) instead of the whole process tree. On Windows the job object cleans up when the script exits. On macOS/Linux a hung python can outlive the script. This only happens after a 5-minute hang.
  • The quoting in the Windows branch is only safe because no argument can contain ", % or !. If a free-text argument is ever added, for example a percent-encoded filter, it will need validation or escaping like --build-id.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-to-review This PR is ready to review/merge, I think any CI failures are just flaky (ignorable).

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants