Fix attribute resolution in recursive module/namespace scopes#19744

Open

T-Gro wants to merge 21 commits into

mainfrom

fix-5795-rec-module-attrs

Commits on Jul 5, 2026

Sprint 01: Test scaffolding for attribute resolution in recursive scopes

authored and
Copilot
committed
Sprint 02: Fix union case attributes in module rec

authored and
Copilot
committed
Sprint 03: Fix record field attributes in module rec

authored and
Copilot
committed
Sprint 04: Fix typar attributes in module rec

authored and
Copilot
committed
Sprint 5: edge-case and negative tests for attribute resolution in rec scopes

authored and
Copilot
committed
Sprint 06: final validation, namespace-rec union case test, release notes

authored and
Copilot
committed
Sprint 07: Fixup #1 — gate typar attr re-resolution, preserve fixup on recoverable exn

authored and
Copilot
committed
Trim verbose comments to short technical notes

authored and
Copilot
committed
Add PR link to release notes

authored and
Copilot
committed
Simplify rec-scope attribute fixup: drop diagnostics-logger beast

authored and
Copilot
committed
De-bloat: unify CanFail attribute-helper family, thread fixups as TcEnv -> unit

authored and
Copilot
committed
De-bloat: fix rec-scope attribute resolution at its root

authored and
Copilot
committed
Compact rec-scope attr fix: revert .fsi churn, reuse combineFixups/List.unzip

authored and
Copilot
committed
Round 2 duck compaction: merge Phase1G match, drop redundant docs

authored and
Copilot
committed
Fix deferred attribute resolution in recursive-scope signature files

authored and
Copilot
committed
Update #5795 conformance tests to expect success after rec-scope attribute fix

Copilot
and
Copilot
committed
Emit union-case AttributeTargets warning for rec-scoped attributes

T-Gro
and
Copilot
committed

Commits on Jul 7, 2026

Commits on Jul 8, 2026

Rename didFail to hasUnresolvedAttrs in TcFieldDecl for clarity

T-Gro
and
Copilot
committed

Commits on Jul 21, 2026

Defer field-only attribute recheck for rec-scoped attribute types

T-Gro
and
Copilot
committed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Fix attribute resolution in recursive module/namespace scopes#19744

Fix attribute resolution in recursive module/namespace scopes#19744
T-Gro wants to merge 21 commits into
mainfrom
fix-5795-rec-module-attrs

Commits on Jul 5, 2026

Sprint 01: Test scaffolding for attribute resolution in recursive scopes

Sprint 02: Fix union case attributes in module rec

Sprint 03: Fix record field attributes in module rec

Sprint 04: Fix typar attributes in module rec

Sprint 5: edge-case and negative tests for attribute resolution in rec scopes

Sprint 06: final validation, namespace-rec union case test, release notes

Sprint 07: Fixup #1 — gate typar attr re-resolution, preserve fixup on recoverable exn

Trim verbose comments to short technical notes

Add PR link to release notes

Simplify rec-scope attribute fixup: drop diagnostics-logger beast

De-bloat: unify CanFail attribute-helper family, thread fixups as TcEnv -> unit

De-bloat: fix rec-scope attribute resolution at its root

Compact rec-scope attr fix: revert .fsi churn, reuse combineFixups/List.unzip

Round 2 duck compaction: merge Phase1G match, drop redundant docs

Fix deferred attribute resolution in recursive-scope signature files

Update #5795 conformance tests to expect success after rec-scope attribute fix

Emit union-case AttributeTargets warning for rec-scoped attributes

Commits on Jul 7, 2026

Consolidate rec-scope attribute fixups into a single deferred-fixup sink

Minimize diff churn in rec-scope attribute fixup

Commits on Jul 8, 2026

Rename didFail to hasUnresolvedAttrs in TcFieldDecl for clarity

Commits on Jul 21, 2026

Defer field-only attribute recheck for rec-scoped attribute types