chore: migrate ZXing library and update target framework by rgunawans · Pull Request #761 · dotnet/maui-samples

rgunawans · 2026-04-19T01:06:36Z

chore: migrate ZXing library and update target framework, compress image, improvement flyout menu

Replace Redth.ZXing.Net.Maui with ZXing.Net.Maui (deprecated)
Enable CAMERA permission in AndroidManifest.xml
Update PointOfSales.API project target framework from .NET 7 to .NET 10
Comparess Images
Improvement flyoutmenu

typo in the description

…d change target on PointOfsales.API projet from .net 7 to .net 10

…able CAMERA permission in Android Manifest, and change target on PointOfsales.API projet from .net 7 to .net 10

- Removed unused ShowMessage method from MobileLoginViewModel - Stopped auto-closing modal after scan in ScanPage - Updated MAUI package versions to use $(MauiVersion) property - Minor formatting fix in AppShellMobile.xaml

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

…inViewModel.cs Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

This reverts commit 9ce127e.

* compressed image * improvement flyout menu in appshell.xaml, sometime it shows text instead of icon * replace DisplayAlert with DisplayAlertySync

Copilot

Pull request overview

Note

Copilot was unable to run its full agentic suite in this review.

Migrates the MAUI barcode scanning library to ZXing.Net.Maui, updates dependencies/target frameworks, and tweaks UI/permissions to support scanning and an improved flyout experience.

Changes:

Replace Redth.ZXing.Net.Maui with ZXing.Net.Maui + add Android CAMERA permission and runtime permission request flow.
Update NuGet packages (MAUI app) and move the API project from .NET 7 to .NET 10 with corresponding package updates.
Flyout menu adjustments (width/layout) and some icon/source updates.

Reviewed changes

Copilot reviewed 12 out of 36 changed files in this pull request and generated 5 comments.

Show a summary per file

File	Description
10.0/Apps/PointOfSale/src/PointOfSale/PointOfSale.csproj	Updates package references and switches ZXing packages.
10.0/Apps/PointOfSale/src/PointOfSale/Platforms/Android/AndroidManifest.xml	Adds CAMERA permission and adjusts application manifest attributes.
10.0/Apps/PointOfSale/src/PointOfSale/Pages/Views/OrderCartViewModel.cs	Changes alert call to `DisplayAlertAsync`.
10.0/Apps/PointOfSale/src/PointOfSale/Pages/SettingsViewModel.cs	Changes alert call to `DisplayAlertAsync`.
10.0/Apps/PointOfSale/src/PointOfSale/Pages/Handheld/ScanPage.xaml.cs	Adds camera permission checks and more robust scanning/navigation handling.
10.0/Apps/PointOfSale/src/PointOfSale/Pages/Handheld/OrdersViewModel.cs	Changes confirmation alert call to `DisplayAlertAsync`.
10.0/Apps/PointOfSale/src/PointOfSale/Pages/Handheld/OrdersPage.xaml	Switches toolbar icons from PNG to SVG.
10.0/Apps/PointOfSale/src/PointOfSale/Pages/Handheld/MobileLoginViewModel.cs	Runs alert on UI thread and switches to `DisplayAlertAsync`.
10.0/Apps/PointOfSale/src/PointOfSale/Pages/DashboardViewModel.cs	Changes alert call to `DisplayAlertAsync`.
10.0/Apps/PointOfSale/src/PointOfSale/MauiProgram.cs	Adds `ZXing.Net.Maui.Controls` using.
10.0/Apps/PointOfSale/src/PointOfSale/AppShell.xaml	Flyout layout changes + adds `FlyoutIcon` on shell content.
10.0/Apps/PointOfSale/src/PointOfSale.API/PointOfSale.API.csproj	Updates API target framework to net10.0 and bumps related packages.

Copilot · 2026-04-19T01:10:21Z

    async Task PlaceOrder()
    {
-        await App.Current.Windows[0].Page.DisplayAlert("Not Implemented", "Wouldn't it be cool tho?", "Okay");
+        await App.Current.Windows[0].Page.DisplayAlertAsync ("Not Implemented", "Wouldn't it be cool tho?", "Okay");


Page.DisplayAlert(...) is already asynchronous in .NET MAUI (returns a Task / Task<bool>), and DisplayAlertAsync is not part of the standard MAUI Page API. Unless the project defines an extension method named DisplayAlertAsync, this will fail to compile. Consider reverting to DisplayAlert(...) (and keep awaiting it) or update the call site to match the actual API you intended to use.

Suggested change

await App.Current.Windows[0].Page.DisplayAlertAsync ("Not Implemented", "Wouldn't it be cool tho?", "Okay");

await App.Current.Windows[0].Page.DisplayAlert("Not Implemented", "Wouldn't it be cool tho?", "Okay");

Copilot · 2026-04-19T01:10:22Z

    public async Task LogOut()
    {
-        var result = await App.Current.Windows[0].Page.DisplayAlert("", "Do you want to logout?", "Yes", "Ooops, no");
+        var result = await App.Current.Windows[0].Page.DisplayAlertAsync ("", "Do you want to logout?", "Yes", "Ooops, no");


Same issue as elsewhere: MAUI’s DisplayAlert is the async API; DisplayAlertAsync is not a standard Page member. This is likely a compile break unless an extension method exists. Prefer DisplayAlert("", "...", "Yes", "...") and await it.

Suggested change

var result = await App.Current.Windows[0].Page.DisplayAlertAsync ("", "Do you want to logout?", "Yes", "Ooops, no");

var result = await App.Current.Windows[0].Page.DisplayAlert("", "Do you want to logout?", "Yes", "Ooops, no");

Copilot · 2026-04-19T01:10:22Z

+                barcodeView.Options = new BarcodeReaderOptions
+                {
+                    Formats = BarcodeFormats.All,
+                    AutoRotate = true,
+                    Multiple = true
+                };


With Multiple = true, BarcodesDetected can fire repeatedly and rapidly, and the current handler navigates (GoToAsync("..")) on the first result each time. This can cause duplicate navigations/races (and navigation exceptions) in real use. A concrete mitigation is to disable detection and/or gate navigation after the first successful scan (e.g., set Multiple = false, or set a private _isNavigating flag and return early on subsequent detections, and/or stop the camera/detection before calling GoToAsync).

Copilot · 2026-04-19T01:10:22Z

+        <ShellContent ContentTemplate="{DataTemplate pages:DashboardPage}" FlyoutIcon="dashboard.png"/>
    </FlyoutItem>
-    <FlyoutItem Title="Settings" Route="settings">
-        <ShellContent ContentTemplate="{DataTemplate pages:SettingsPage}"/>
+    <FlyoutItem Title="Settings" Route="settings" >
+        <ShellContent ContentTemplate="{DataTemplate pages:SettingsPage}" FlyoutIcon="settings.png"/>


These FlyoutIcon file names don’t match the image names used elsewhere in the same file (graph.png, setting.png, etc.). If dashboard.png / settings.png aren’t present in the app resources, the flyout icons will be missing at runtime. Use the actual resource names (or rename the assets consistently) so the flyout icons resolve correctly.

Copilot · 2026-04-19T01:10:23Z

 <manifest xmlns:android="http://schemas.android.com/apk/res/android" package="net.dot.pointofsale" android:versionCode="1" android:versionName="1.0.0">
-	<uses-sdk android:minSdkVersion="21" android:targetSdkVersion="34" />
-	<application android:allowBackup="true" android:icon="@mipmap/appicon" android:roundIcon="@mipmap/appicon_round" android:supportsRtl="true" android:label="Food">
+	<application android:allowBackup="true" android:icon="@mipmap/appicon" android:supportsRtl="true" android:label="Food">


The manifest change removes android:roundIcon. If the project still provides a round icon resource (@mipmap/appicon_round), dropping roundIcon can cause inconsistent launcher icon rendering on some devices/launchers. Consider keeping android:roundIcon="@mipmap/appicon_round" if that resource still exists.

Suggested change

<application android:allowBackup="true" android:icon="@mipmap/appicon" android:supportsRtl="true" android:label="Food">

<application android:allowBackup="true" android:icon="@mipmap/appicon" android:roundIcon="@mipmap/appicon_round" android:supportsRtl="true" android:label="Food">

* compressed image * improvement flyout menu in appshell.xaml, sometime it shows text instead of icon * replace DisplayAlert with DisplayAlertySync * Replace TranslateTo with TranslateToAsync * Replace FadeTo with FadeToAsync

Updated the GitHub Actions workflow to include a build step for Windows and removed redundant steps for Android and macOS builds.

Added a step to restore dependencies before building the Windows project.

Refactored build-pr.yml for concise steps and added a Windows build job. Added Microsoft.Maui.Controls.Compatibility to PointOfSale.csproj and downgraded Microsoft.Maui.Controls and WebView.Maui to 10.0.41. Updated global.json to use .NET SDK 10.0.202 with latestPatch rollForward.

Updated GitHub Actions workflow to simplify and clarify build steps for macOS and Windows jobs. Now both jobs install the .NET 10 SDK and MAUI workload before building the Android target. Removed redundant steps and consolidated tasks for improved efficiency.

Refactored build-pr.yml to introduce separate jobs for macOS and Windows alongside Android. Each job now sets up .NET 10, installs the MAUI workload, and builds the PointOfSale project for its respective platform. This replaces the previous single Android build with platform-specific, granular steps.

Removed the macOS build job from build-pr.yml and added a Windows build job. The new job sets up .NET 10.0.x, installs the MAUI workload, restores dependencies, and builds the project for the Windows target framework.

Updated .NET version to 10.0 and added MAUI workload installation for Android, Windows, and macOS builds.

rgunawans and others added 12 commits April 17, 2026 17:21

Update application description in README.md

f0db671

typo in the description

Merge branch 'dotnet:main' into main

839e831

since Redth.ZXing.Net.Maui deprecated, change with ZXing.Net.Maui, an…

2c4cffc

…d change target on PointOfsales.API projet from .net 7 to .net 10

Merge branch 'main' of https://github.com/rgunawans/maui-samples

2371028

since Redth.ZXing.Net.Maui deprecated, change with ZXing.Net.Maui, en…

6c53edf

…able CAMERA permission in Android Manifest, and change target on PointOfsales.API projet from .net 7 to .net 10

Refactor UI logic and update MAUI package references

9ce127e

- Removed unused ShowMessage method from MobileLoginViewModel - Stopped auto-closing modal after scan in ScanPage - Updated MAUI package versions to use $(MauiVersion) property - Minor formatting fix in AppShellMobile.xaml

Update 10.0/Apps/PointOfSale/src/PointOfSale/PointOfSale.csproj

cc917a7

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Update 10.0/Apps/PointOfSale/src/PointOfSale/Pages/Handheld/MobileLog…

2a7ebce

…inViewModel.cs Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Update 10.0/Apps/PointOfSale/src/PointOfSale/AppShellMobile.xaml

d9cc38f

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Revert "Refactor UI logic and update MAUI package references"

75f283d

This reverts commit 9ce127e.

Merge branch 'main' of https://github.com/rgunawans/maui-samples

f53ec62

improvement :

7d9be95

* compressed image * improvement flyout menu in appshell.xaml, sometime it shows text instead of icon * replace DisplayAlert with DisplayAlertySync

Copilot AI review requested due to automatic review settings April 19, 2026 01:06

Copilot started reviewing on behalf of rgunawans April 19, 2026 01:07 View session

Copilot AI reviewed Apr 19, 2026

View reviewed changes

rgunawans added 15 commits April 19, 2026 13:24

improvement :

732e2a0

* compressed image * improvement flyout menu in appshell.xaml, sometime it shows text instead of icon * replace DisplayAlert with DisplayAlertySync * Replace TranslateTo with TranslateToAsync * Replace FadeTo with FadeToAsync

Merge branch 'main' of https://github.com/rgunawans/maui-samples

a457039

Update SDK version and rollForward settings

ed37e36

Update SDK version and rollForward settings

078104c

Merge branch 'main' of https://github.com/rgunawans/maui-samples

3a35336

Update workflow to build Android project for PR

dd744b8

Update .NET SDK version to 10.0.x

b71ab93

Update .NET SDK version to 10.0.x

5b22bc4

Merge branch 'main' of https://github.com/rgunawans/maui-samples

acb14bf

Enhance build workflow for Android, macOS, and Windows

7514e04

Updated the GitHub Actions workflow to include a build step for Windows and removed redundant steps for Android and macOS builds.

Fix formatting in build-pr.yml for dotnet build commands

28601e3

Enhance Windows build workflow with dependency restoration

fe690f3

Added a step to restore dependencies before building the Windows project.

Refactor build-windows section in workflow

dfa108a

rgunawans added 9 commits April 19, 2026 20:29

Update CI: replace macOS build with Windows build

01ed4c1

Removed the macOS build job from build-pr.yml and added a Windows build job. The new job sets up .NET 10.0.x, installs the MAUI workload, restores dependencies, and builds the project for the Windows target framework.

Update build-pr.yml

6ce733f

Update build-pr.yml

1c7efa4

Update build-pr.yml

1e6b8b8

Update build-pr.yml

9eb4d0b

Update build-pr.yml

2b558f6

Upgrade .NET to 10.0 and add MAUI workload installation

bee54a1

Updated .NET version to 10.0 and added MAUI workload installation for Android, Windows, and macOS builds.

Rename workflow from 'Build Project for PR' to 'build'

32c1e62

rgunawans closed this Apr 28, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore: migrate ZXing library and update target framework#761

chore: migrate ZXing library and update target framework#761
rgunawans wants to merge 36 commits into
dotnet:mainfrom
rgunawans:main

rgunawans commented Apr 19, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Apr 19, 2026

Uh oh!

Copilot AI Apr 19, 2026

Uh oh!

Copilot AI Apr 19, 2026

Uh oh!

Copilot AI Apr 19, 2026

Uh oh!

Copilot AI Apr 19, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

	await App.Current.Windows[0].Page.DisplayAlertAsync ("Not Implemented", "Wouldn't it be cool tho?", "Okay");
	await App.Current.Windows[0].Page.DisplayAlert("Not Implemented", "Wouldn't it be cool tho?", "Okay");

	var result = await App.Current.Windows[0].Page.DisplayAlertAsync ("", "Do you want to logout?", "Yes", "Ooops, no");
	var result = await App.Current.Windows[0].Page.DisplayAlert("", "Do you want to logout?", "Yes", "Ooops, no");

	<application android:allowBackup="true" android:icon="@mipmap/appicon" android:supportsRtl="true" android:label="Food">
	<application android:allowBackup="true" android:icon="@mipmap/appicon" android:roundIcon="@mipmap/appicon_round" android:supportsRtl="true" android:label="Food">

Conversation

rgunawans commented Apr 19, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI Apr 19, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 19, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 19, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 19, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 19, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants