Skip to content

Switch 0w ERG targets to sim mode #736

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
Copilot wants to merge 4 commits into
base: develop
Choose a base branch
from
+16 −3
Draft

Switch 0w ERG targets to sim mode #736

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
0b63f32
Initial plan
Copilot May 12, 2026
bc373eb
Switch zero-watt ERG targets to sim mode
Copilot May 12, 2026
6c5fdc6
Address ERG free-ride review feedback
Copilot May 12, 2026
cc7c001
Inline zero-watt ERG check
Copilot May 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 15 additions & 2 deletions src/BLE_Fitness_Machine_Service.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -245,9 +245,22 @@ void BLE_Fitness_Machine_Service::processFTMSWrite() {

case FitnessMachineControlPointProcedure::SetTargetPower: {
rtConfig->setFTMSMode((uint8_t)rxValue[0]);
if (spinBLEClient.connectedPM || rtConfig->watts.getSimulate() || spinBLEClient.connectedCD) {
uint16_t requestedTargetPower = bytes_to_u16(rxValue[2], rxValue[1]);
if (requestedTargetPower == 0) {
// Default sim params: wind 0, grade 0%, rolling resistance 0x28, wind resistance 0x33.
const uint8_t simMode[] = {FitnessMachineControlPointProcedure::SetIndoorBikeSimulationParameters, 0x00, 0x00, 0x00, 0x00, 0x28, 0x33};
rtConfig->setFTMSMode(FitnessMachineControlPointProcedure::SetIndoorBikeSimulationParameters);
rtConfig->watts.setTarget(0);
rtConfig->setTargetIncline(0);
returnValue[2] = FitnessMachineControlPointResultCode::Success;
logBufLength +=
snprintf(logBuf + logBufLength, kLogBufCapacity - logBufLength, "-> ERG Mode Target: %dw, switching to Sim Mode", requestedTargetPower);
ftmsStatus = {FitnessMachineStatus::IndoorBikeSimulationParametersChanged, simMode[1], simMode[2], simMode[3], simMode[4], simMode[5], simMode[6]};
ftmsTrainingStatus[1] = FitnessMachineTrainingStatus::ManualMode;
spinBLEClient.FTMSControlPointWrite(simMode, sizeof(simMode));
} else if (spinBLEClient.connectedPM || rtConfig->watts.getSimulate() || spinBLEClient.connectedCD) {
returnValue[2] = FitnessMachineControlPointResultCode::Success; // 0x01;
rtConfig->watts.setTarget(bytes_to_u16(rxValue[2], rxValue[1]));
rtConfig->watts.setTarget(requestedTargetPower);
logBufLength += snprintf(logBuf + logBufLength, kLogBufCapacity - logBufLength, "-> ERG Mode Target: %d Current: %d Incline: %2f", rtConfig->watts.getTarget(),
rtConfig->watts.getValue(), rtConfig->getTargetIncline() / 100);
ftmsStatus = {FitnessMachineStatus::TargetPowerChanged, (uint8_t)rxValue[1], (uint8_t)rxValue[2]};
Expand Down
2 changes: 1 addition & 1 deletion test/test_unity.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -123,4 +123,4 @@ int main(int argc, char** argv) {
setup();
return 0;
}
#endif
#endif