Changes mostly related to virtual and imapsieve parts #1289

szotsaki · 2025-08-27T10:54:59Z

Extended the documentation with smaller fixes and added some examples that were hard to come by.

Additionally, added caveats where the implementation doesn't support something in order for other users not to debug it again.

szotsaki · 2025-08-27T10:55:35Z

docs/core/plugins/virtual.md

+Beware that `*` will not match any mailbox that already has a more
 specialized match!

+Currently, `*` doesn't match INBOX.


We can debug that further in the mailing list why you're seeing that, but this definitely is not generally true, so can't include it in documentation.

szotsaki · 2025-08-27T10:56:32Z

docs/core/plugins/virtual.md

 saving via Virtual/All folder.

+::: warning
+Currently, imapsieve scripts that are defined within a virtual mailbox are not being called.


Isn't this just restating what the text above is trying to say? "When saving to a virtual mailbox is configured, imapsieve scripts act as if the save was done directly to the physical destination mailbox". Maybe it could be further clarified, but now this sounds like a separate issue, while I think it's the same. I.e. Sieve scripts work only on physical mailboxes, not virtual mailboxes.

szotsaki · 2025-08-27T10:57:31Z

docs/core/settings/syntax.md

+group @namespaces-virtual english {
+  namespace virtual {
+    prefix = virtual/
+
+    mail_driver = virtual
+    mail_path = /var/lib/dovecot/virtual/en
+    mail_index_path = %{home}/index/virtual/en
+
+    mailbox All {
+      auto = no
+      special_use = \All
+    }
+    mailbox Flagged {
+      auto = no
+      special_use = \Flagged
+    }
+  }
+}


There is something wrong in group handling here, but if it is documented, it needs to be clearer what is wrong. This is both a too specific example of what doesn't work, and also at the same time it's too wide, like I don't think the mailbox { .. } are relevant. I'll see if I can understand what is going wrong there.

szotsaki · 2025-08-27T10:57:50Z

docs/core/settings/syntax.md

 ```

+::: warning
+Currently, indices are not created for namespaces that are defined within groups.


I think this is the same bug as above. Something's not working right in group handling.

cmouse · 2025-08-27T10:58:38Z

docs/core/plugins/imap_sieve.md

 does not need to be added to the [[setting,sieve_extensions]] setting.

+Additional information about using the plugin with virtual mailboxes can be
+found at [[link,imapsieve-filters,virtual mailbox plugin]].


[vitepress] Dovecot link missing: imapsieve-filters

I'm not really familiar with Vitepress builds. I'd like to link to IMAPSieve Filters page. What would be the correct link in this case?

you need to add a link anchor there first, see other pages for examples

I modified the source. I don't see the CI failing with its check but github interface is bit ambiguous when these checks should run.

szotsaki · 2025-08-27T11:05:51Z

docs/core/settings/syntax.md

+Within one group it's not possible to enumerate different kind of settings, like
+`prefix`, `separator`, and multiple `mailboxes`. For these cases, include the
+hierarchy one above, like `namespace`. For example:


I definitely saw that namespace elements within a group (like prefix, separator, etc., except for mailbox) are not allowed.

Is my generalisation correct that mixing elements is not supported, or is it supported but some elements are excluded from this support?

cmouse · 2025-11-09T13:32:11Z

needs local rebase

szotsaki · 2025-11-15T20:47:56Z

Rebase is done

sirainen · 2025-12-12T12:04:55Z

docs/core/man/sieve-test.1.md

 problems that are reported by the Sieve plugin, for example by tracing
 the execution and evaluation of commands and tests respectively.

+The tool does not parse the userdb database. If virtual users have different


"The tool does not perform a userdb lookup." is a more correct way of saying this.

"If users have ..." - there's no need to say "virtual" since the same applies to system users as well.

sirainen · 2025-12-12T12:09:07Z

docs/core/man/include/doveadm-backup-sync.inc

 **-t** *start date*
 :   Skip any mails whose received-timestamp is older than the specified time.
+    The format follows IMAP4rev1 standard format, e.g. "13-Apr-2007 14:23:05
+    +0200"


This is only partially true. Better would be to add a reference to the full syntax possibilities: For the timestamp format, see the DATE SPECIFICATION in [[man,doveadm-search-query,,7]].

sirainen · 2025-12-12T12:10:02Z

docs/core/plugins/imap_sieve.md

 Script storages for administrator scripts are defined in
 [[setting,sieve_script]] blocks with [[setting,sieve_script_type]]
-[[link,sieve_storage_type_before,before]] or
+ [[link,sieve_storage_type_before,before]] or


unnecessary whitespace change?

sirainen · 2025-12-12T12:14:49Z

docs/core/plugins/virtual.md


 ```[dovecot.conf]
-namespace {
+namespace virtual {


Looks like there are a ton of these missing. Fixing them all in #1376

sirainen · 2025-12-12T12:15:34Z

docs/core/plugins/virtual.md

+    auto = no
+    special_use = \All
+  }
+  [...]


I think better not include [...] since there's not necessarily any additional configs, and makes copypasting more difficult.

sirainen · 2025-12-12T12:35:51Z

docs/core/plugins/virtual.md

+Beware that `*` will not match any mailbox that already has a more
 specialized match!

+Currently, `*` doesn't match INBOX.


We can debug that further in the mailing list why you're seeing that, but this definitely is not generally true, so can't include it in documentation.

sirainen · 2025-12-12T12:46:21Z

docs/core/settings/syntax.md

+group @namespaces-virtual english {
+  namespace virtual {
+    prefix = virtual/
+
+    mail_driver = virtual
+    mail_path = /var/lib/dovecot/virtual/en
+    mail_index_path = %{home}/index/virtual/en
+
+    mailbox All {
+      auto = no
+      special_use = \All
+    }
+    mailbox Flagged {
+      auto = no
+      special_use = \Flagged
+    }
+  }
+}


There is something wrong in group handling here, but if it is documented, it needs to be clearer what is wrong. This is both a too specific example of what doesn't work, and also at the same time it's too wide, like I don't think the mailbox { .. } are relevant. I'll see if I can understand what is going wrong there.

sirainen · 2025-12-12T12:47:48Z

docs/core/settings/syntax.md

 ```

+::: warning
+Currently, indices are not created for namespaces that are defined within groups.


I think this is the same bug as above. Something's not working right in group handling.

szotsaki commented Aug 27, 2025

View reviewed changes

cmouse reviewed Aug 27, 2025

View reviewed changes

szotsaki commented Aug 27, 2025

View reviewed changes

szotsaki force-pushed the main branch from 50a35b6 to 920b496 Compare August 28, 2025 07:57

szotsaki force-pushed the main branch from 0348704 to 4109346 Compare November 14, 2025 07:43

szotsaki added 5 commits December 10, 2025 07:58

Changes mostly related to virtual and imapsieve parts

0adbad9

doveadm sync: clarify -t/-e formats

caf47dc

mailbox formats: Fix fsync typo

14bcb82

Sieve test: clarify userdb handling

ea969d0

doveadm fs: fix example syntax

5985454

cmouse force-pushed the main branch from 4109346 to 5985454 Compare December 10, 2025 05:58

sirainen requested changes Dec 12, 2025

View reviewed changes

Changes mostly related to virtual and imapsieve parts #1289

Are you sure you want to change the base?

Changes mostly related to virtual and imapsieve parts #1289

Uh oh!

Conversation

szotsaki commented Aug 27, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

cmouse commented Nov 9, 2025

Uh oh!

szotsaki commented Nov 15, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants