macOS: bump baseline to 10.15, fix GL_SILENCE_DEPRECATION placement - #62
Merged
Merged
Conversation
resourcedata_mac.mm: - Remove @available(macOS 10.15, *) guard around monospacedSystemFontOfSize:weight: - Drop systemFontOfSize: fallback — 10.15 is now the minimum supported version cocoa_display_window.mm: - Move GL_SILENCE_DEPRECATION before OpenGL header imports so it actually silences the deprecation warnings (defining it after the headers have no effect) - Wrap initOpenGL() NSOpenGL usage in -Wdeprecated-declarations pragmas for cleaner builds on macOS 12+ Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Owner
|
I had to force push the master branch because this commit included copilot ad spam. I appreciate the PR itself, but please make sure in the future that AI companies do not inject spam into your work. :) |
Contributor
Author
|
Ah I see. No worries, I was a little lazy pushing out the last few commits for the renderer as it was failing cross platform builds so asked copilot to create a new branch. I should have checked the commit a little better. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
resourcedata_mac.mm:
cocoa_display_window.mm:
Hi dpjudas,
I've bumped the minimum version for macOS to 10.15+ from 10.13+ because the ShaderCompiler library I'm using has glsl-lang support at 10.15+ minimum. Metal renderer is feature complete, I'll post to the forums soon and as promised will start the HaikuOS porting at some stage.