Skip to content

dash: Fix background hovering effect - #194

Merged
EliverLara merged 1 commit into
dracula:dashfrom
ran-dall:add-dash-to-dock-support
Jun 19, 2022
Merged

dash: Fix background hovering effect#194
EliverLara merged 1 commit into
dracula:dashfrom
ran-dall:add-dash-to-dock-support

Conversation

@ran-dall

@ran-dall ran-dall commented Jun 2, 2022

Copy link
Copy Markdown
Contributor

(...in a way continues #190)

As noted by @pasan93 in #190 (comment), the hovering effect wasn't working.

@EliverLara This PR fixes that on the dash branch. Also, the formatting uses dart-sass hence all the trivial style differences.

@EliverLara EliverLara left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it just me or does it look like the _dash-to-dock.scss file hasn't been rendered in gtk.css?

@ran-dall

ran-dall commented Jun 2, 2022

Copy link
Copy Markdown
Contributor Author

@EliverLara Is it supposed to render in gtk.css? I think if it is, then maybe the Gulpfile.js needs an update cause it's not set up to render changes in gnome-shell outside of ./gnome-shell. I believe gtk.css is inside gtk-4.0 so it won't get rendered because it isn't gnome-shell (which only renders out to ./gnome-shell/).

BTW there are no rules on Gulp to render out to gtk-4.0, I just noticed. It's still set up to 3.20 only. Maybe I'll do that later today and add it to #193.

@EliverLara EliverLara left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm sorry, I meant gnome-shell.css

Comment thread gnome-shell/v40/gnome-shell.css
@ran-dall
ran-dall force-pushed the add-dash-to-dock-support branch from 3f9aa22 to d855c44 Compare June 2, 2022 21:10
@ran-dall

Copy link
Copy Markdown
Contributor Author

@EliverLara What did you want to do about this? I see that we're already several commits out of alignment with the main tree. Did you want to work on #193 first, so we can establish the right syntax rules for newer contributors, such as myself?

@EliverLara
EliverLara merged commit 825f90e into dracula:dash Jun 19, 2022
@EliverLara

Copy link
Copy Markdown
Member

@ran-dall Sorry for the delayed reply, I just merged it and I'll add it to the master branch, thank you so much for your contributions!, now I'll take a look to #193 in order to provide feedback to you.

@ran-dall
ran-dall deleted the add-dash-to-dock-support branch June 20, 2022 19:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants