Fixes water_deep_cm, adds bat_percent and updated some internals#35
Open
s2patrick wants to merge 2 commits into
Open
Fixes water_deep_cm, adds bat_percent and updated some internals#35s2patrick wants to merge 2 commits into
s2patrick wants to merge 2 commits into
Conversation
// Differences & Fixes compared to the original Dragino decoder: // • Bugfix: Water_deep_cm often stayed 0 → now recalculated from IDC_input_mA as fallback. // • Auto-detection of two byte layouts (IDC/VDC swapped) → decoder chooses the plausible one. // • Battery values: Auto-scaling (×0.01 vs ×0.001) fixes mis‑decoded voltages. // • New: Bat_percent field (battery %). For PS‑LS → Li‑Ion curve, for PS‑LB → Li‑SOCl2 curve. // • New: raw_hex & layout fields for easier diagnostics. // • Node_type is automatically distinguished between PS‑LB / PS‑LS (solar voltage detection).
Refactor batPctLiSOCl2 function to improve readability and update interpolation points.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
// Differences & Fixes compared to the original Dragino decoder:
// • Bugfix: Water_deep_cm often stayed 0 → now recalculated from IDC_input_mA as fallback.
// • Auto-detection of two byte layouts (IDC/VDC swapped) → decoder chooses the plausible one.
// • Battery values: Auto-scaling (×0.01 vs ×0.001) fixes mis‑decoded voltages.
// • New: Bat_percent field (battery %). For PS‑LS → Li‑Ion curve, for PS‑LB → Li‑SOCl2 curve.
// • New: raw_hex & layout fields for easier diagnostics.
// • Node_type is automatically distinguished between PS‑LB / PS‑LS (solar voltage detection).