Skip to content

feat: add per-component probe overrides#503

Open
snigdhasambitak wants to merge 1 commit into
dragonflyoss:mainfrom
snigdhasambitak:feat/per-component-probes
Open

feat: add per-component probe overrides#503
snigdhasambitak wants to merge 1 commit into
dragonflyoss:mainfrom
snigdhasambitak:feat/per-component-probes

Conversation

@snigdhasambitak

@snigdhasambitak snigdhasambitak commented May 11, 2026

Copy link
Copy Markdown
Contributor

What

Per-component startupProbe / readinessProbe / livenessProbe override blocks on manager, scheduler, seedClient, client, injector. Component fields win; unset fields fall back to the existing global.

Why

#501 had per-component startupProbe. #498's squash-merge collapsed it into one global block, not called out in any commit message. One timing fits no component well: seedClient cold-boots in 60-120s and needs slack, manager wants tight liveness. We hit manager liveness flap on cold boot in our clusters today.

Example

# enable startup on slow components only
client:
  startupProbe:
    enable: true
seedClient:
  startupProbe:
    enable: true
    failureThreshold: 90  # ~7.5 min for cold cache hydration
# manager keeps the global default (startup disabled, tight liveness)

No override = zero diff vs main (verified by helm template byte-diff). Helper uses hasKey since sprig merge drops explicit zero values. Chart 1.6.26 → 1.6.27, README regenerated.

Signed-off-by: Snigdha Aryakumar <snigdha.sambit.ak@gmail.com>
@snigdhasambitak

Copy link
Copy Markdown
Contributor Author

@imeoer @gaius-qi @CormickKneey could one of you add the enhancement label so the Classify PR check passes? External contributors can't apply labels themselves. Thanks.

@gaius-qi gaius-qi added the enhancement New feature or request label May 11, 2026
@snigdhasambitak

Copy link
Copy Markdown
Contributor Author

Any reviews or feedbacks? This will help us to override the probes. So can this be reviewed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants