feat: add per-component probe overrides#503
Open
snigdhasambitak wants to merge 1 commit into
Open
Conversation
Signed-off-by: Snigdha Aryakumar <snigdha.sambit.ak@gmail.com>
Contributor
Author
|
@imeoer @gaius-qi @CormickKneey could one of you add the |
Contributor
Author
|
Any reviews or feedbacks? This will help us to override the probes. So can this be reviewed? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Per-component
startupProbe/readinessProbe/livenessProbeoverride blocks on manager, scheduler, seedClient, client, injector. Component fields win; unset fields fall back to the existing global.Why
#501 had per-component startupProbe. #498's squash-merge collapsed it into one global block, not called out in any commit message. One timing fits no component well: seedClient cold-boots in 60-120s and needs slack, manager wants tight liveness. We hit manager liveness flap on cold boot in our clusters today.
Example
No override = zero diff vs main (verified by
helm templatebyte-diff). Helper useshasKeysince sprigmergedrops explicit zero values. Chart 1.6.26 → 1.6.27, README regenerated.