This repository was archived by the owner on Sep 30, 2025. It is now read-only.
refactor: decoupled strike run status literal from cli #8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ENG-179 CLI: Decouple StrikeRunStatus literal values from agent.cli.deploy
This https://github.com/dreadnode/cli/blob/main/dreadnode_cli/agent/cli.py#L206 should be a helper method of the StrikeRunStatus model. |
Contributor
Author
|
@monoxgas i'm not super happy about this as these value could/will change over time, maybe we can add an additional boolean flag to the _StrikeRun model that's computed server side? |
evilsocket
deleted the
feature/eng-179-cli-decouple-strikerunstatus-literal-values-from
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes https://linear.app/dreadnode/issue/ENG-179/cli-decouple-strikerunstatus-literal-values-from-agentclideploy