refactor: type safety, architecture cleanup, and test coverage improvements#26
Open
vantreeseba wants to merge 12 commits into
Open
refactor: type safety, architecture cleanup, and test coverage improvements#26vantreeseba wants to merge 12 commits into
vantreeseba wants to merge 12 commits into
Conversation
…pedef Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…t belongs Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…d English keys Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…omXxxSet functions Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…lass expansions Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
… assignment in struct literal Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…nitialize instance field Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…ss, and phrase subject assertions Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…ilants, liquids, finals, ortho Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…raphyTest Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…s to RewriteTest Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Array<Dynamic>rewriteset with a typedRewriteRuletypedef acrossRewrite,Language, andConstsMap<String, String>return type toLanguage.translateGraphemestypedef fromLanguage.hxtoOrthography.hxwhere it belongscreatePhrasenoun filter to compare generated word values instead of hardcoded English keys ("the"/"of")randomFromMaphelper inConsts, eliminating 8 duplicategetRandomXxxSetmethod bodies{1}quantifiers fromRewrite.parseRulecharacter class expansionsrandomminbefore the config block to remove a side-effect assignment inside a struct literal@BeforeClass→@BeforeinOrthographyTestso the instance field is correctly initialized per testConstsgetter coverageTest plan
npm test)🤖 Generated with Claude Code